Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW RESOURCE] SQL ElasticPool using 2017-10-01-preview API #2071

Merged
merged 43 commits into from
Nov 14, 2018

Conversation

WodansSon
Copy link
Collaborator

@WodansSon WodansSon commented Oct 13, 2018

(fixes #1605)
(fixes #1745)
(fixes #1931)

@ghost ghost added the size/XXL label Oct 13, 2018
@metacpp metacpp added this to the Soon milestone Oct 15, 2018
@metacpp metacpp added the service/mssql Microsoft SQL Server label Oct 15, 2018
@metacpp
Copy link
Contributor

metacpp commented Oct 20, 2018

@jeffreyCline Please fix the building error, add test case and doc.

@tombuildsstuff tombuildsstuff modified the milestones: Soon, Being Sorted Oct 25, 2018
@WodansSon
Copy link
Collaborator Author

image

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jeffreyCline,

Thanks for renaming the resource. In addition to the comments i've left inline the documentation is missing the import section.

azurerm/config.go Outdated Show resolved Hide resolved
azurerm/helpers/azure/validate.go Outdated Show resolved Hide resolved
azurerm/resource_arm_mssql_elasticpool.go Outdated Show resolved Hide resolved
azurerm/resource_arm_mssql_elasticpool.go Outdated Show resolved Hide resolved
azurerm/resource_arm_mssql_elasticpool.go Show resolved Hide resolved
azurerm/resource_arm_mssql_elasticpool.go Outdated Show resolved Hide resolved
azurerm/resource_arm_mssql_elasticpool.go Outdated Show resolved Hide resolved
azurerm/resource_arm_mssql_elasticpool.go Outdated Show resolved Hide resolved
azurerm/resource_arm_mssql_elasticpool_test.go Outdated Show resolved Hide resolved
azurerm/resource_arm_mssql_elasticpool_test.go Outdated Show resolved Hide resolved
@WodansSon
Copy link
Collaborator Author

image

WodansSon and others added 4 commits November 13, 2018 20:18
Co-Authored-By: jeffreyCline <jcline@microsoft.com>
Co-Authored-By: jeffreyCline <jcline@microsoft.com>
Co-Authored-By: jeffreyCline <jcline@microsoft.com>
@katbyte katbyte force-pushed the u-elasticPool-2017-10-01-preview branch from b4f4ff2 to 900b6a2 Compare November 14, 2018 21:46
@katbyte
Copy link
Collaborator

katbyte commented Nov 14, 2018

Tests still pass:
screen shot 2018-11-14 at 14 52 42

@katbyte katbyte added this to the 1.19.0 milestone Nov 14, 2018
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now 👍

@katbyte katbyte merged commit a66955b into master Nov 14, 2018
@katbyte katbyte deleted the u-elasticPool-2017-10-01-preview branch November 14, 2018 22:56
katbyte added a commit that referenced this pull request Nov 14, 2018
@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
4 participants