Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMSS: support for eviction policy #2226

Merged
merged 1 commit into from
Nov 4, 2018
Merged

Conversation

tombuildsstuff
Copy link
Contributor

Fixes #1690

@tombuildsstuff tombuildsstuff added enhancement service/vmss Virtual Machine Scale Sets labels Nov 3, 2018
@tombuildsstuff tombuildsstuff added this to the 1.19.0 milestone Nov 3, 2018
@ghost ghost added the size/M label Nov 3, 2018
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outside of a single comment LGTM 👍

website/docs/r/virtual_machine_scale_set.html.markdown Outdated Show resolved Hide resolved
@tombuildsstuff tombuildsstuff force-pushed the vmss-eviction-policy branch 2 times, most recently from dc46dce to 2492ee1 Compare November 4, 2018 15:48
@ghost ghost added size/L and removed size/M labels Nov 4, 2018
@tombuildsstuff
Copy link
Contributor Author

Tests pass:

screenshot 2018-11-04 at 21 12 02

@tombuildsstuff tombuildsstuff merged commit a05151f into master Nov 4, 2018
@tombuildsstuff tombuildsstuff deleted the vmss-eviction-policy branch November 4, 2018 21:14
tombuildsstuff added a commit that referenced this pull request Nov 4, 2018
@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement service/vmss Virtual Machine Scale Sets size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants