Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: azurerm_iothub_consumer_group #2243

Merged
merged 4 commits into from
Nov 6, 2018
Merged

New Resource: azurerm_iothub_consumer_group #2243

merged 4 commits into from
Nov 6, 2018

Conversation

tombuildsstuff
Copy link
Contributor

Tests pass:

$ acctests azurerm TestAccAzureRMIotHubConsumerGroup_
=== RUN   TestAccAzureRMIotHubConsumerGroup_events
--- PASS: TestAccAzureRMIotHubConsumerGroup_events (280.43s)
=== RUN   TestAccAzureRMIotHubConsumerGroup_operationsMonitoringEvents
--- PASS: TestAccAzureRMIotHubConsumerGroup_operationsMonitoringEvents (211.24s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	493.476s

Fixes #2230

@tombuildsstuff
iothub: refactoring
521af20
@tombuildsstuff
New Resource: azurerm_iothub_consumer_group
6ba4fbc 
Tests pass:
```
$ acctests azurerm TestAccAzureRMIotHubConsumerGroup_
=== RUN   TestAccAzureRMIotHubConsumerGroup_events
--- PASS: TestAccAzureRMIotHubConsumerGroup_events (280.43s)
=== RUN   TestAccAzureRMIotHubConsumerGroup_operationsMonitoringEvents
--- PASS: TestAccAzureRMIotHubConsumerGroup_operationsMonitoringEvents (211.24s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	493.476s
```

Fixes #2230
@tombuildsstuff
adding validation for iothub names
393c13b 
Tests pass:

```
=== RUN   TestValidateIoTHubName
--- PASS: TestValidateIoTHubName (0.00s)
=== RUN   TestValidateIoTHubConsumerGroupName
--- PASS: TestValidateIoTHubConsumerGroupName (0.00s)
PASS
```
@tombuildsstuff tombuildsstuff added this to the 1.19.0 milestone Nov 5, 2018
@ghost ghost added the size/XL label Nov 5, 2018
@tombuildsstuff tombuildsstuff requested a review from a team November 5, 2018 12:21
katbyte
katbyte approved these changes Nov 6, 2018
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from two very minor comments 👍

azurerm/resource_arm_iothub_consumer_group_test.go Outdated Show resolved Hide resolved
azurerm/resource_arm_iothub_consumer_group_test.go Outdated Show resolved Hide resolved
@tombuildsstuff tombuildsstuff merged commit aaaf121 into master Nov 6, 2018
@tombuildsstuff tombuildsstuff deleted the f/iothub-consumer-group branch November 6, 2018 11:48
tombuildsstuff added a commit that referenced this pull request Nov 6, 2018
@tombuildsstuff
Updating to include #2243
5e93675
@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
new-resource service/iot-hub size/XL
Projects
None yet
Milestone
v1.19.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tombuildsstuff @katbyte