Allowed larger numbers for azurerm_shared_image_version name

[katbyte]

fixes #2283

[katbyte]

Tests pass:

==> Fixing source code with gofmt...
gofmt -s -w ./azurerm
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./azurerm -v -test.run=TestAccAzureRMSharedImageVersion_basic -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMSharedImageVersion_basic
=== PAUSE TestAccAzureRMSharedImageVersion_basic
=== CONT  TestAccAzureRMSharedImageVersion_basic
--- PASS: TestAccAzureRMSharedImageVersion_basic (1958.02s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	1959.705s

[tombuildsstuff]

LGTM 👍

[whytoe]

Thanks you guys are the best! @tombuildsstuff @katbyte . This was causing a bunch of issues because it looks like Azure isnt updating the source -> managedImage -> id within our pipeline(below json put parameter from Azure Rest Browser). Terraform says it updated the Shared_image_version but when the image was provisioned it was the old image.

We had 0.0.1 Hard-coded until this issue was fixed but it may require more investigating, if its you or them on the update function.

"source": {
        "managedImage": {
          "id": "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroup}/providers/Microsoft.Compute/images/{imageName}"

[tombuildsstuff]

@whytoe is this within a VM Scale Set? if so there's an explicit upgrade API endpoint/method that can be called which cycles the machines in the Scale Set

[whytoe]

@tombuildsstuff no this is just to commit a new Source Managed Image ID to the same version number in the shared gallery

Example 
ID 
"id": "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroup}/providers/Microsoft.Compute/images/ImageName1"

Then I update the ID but I keep the same image version number

"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroup}/providers/Microsoft.Compute/images/ImageName2"

Terraform will state that it has updated the shared image version in 2 minutes (first time it takes about 10-15 minutes). But the Image will not actually update.

[tombuildsstuff]

@whytoe mind opening a separate issue about that?

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!