Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Service Fabric Reverse Proxy Certificate and Endpoint in Nodetype #2544

Merged
merged 5 commits into from
Dec 26, 2018
Merged

Added Service Fabric Reverse Proxy Certificate and Endpoint in Nodetype #2544

merged 5 commits into from
Dec 26, 2018

Conversation

joranm
Copy link
Contributor

@joranm joranm commented Dec 19, 2018

Added reverse_proxy_certificate and reverse_proxy_endpoint_port to the azurerm_service_fabric_cluster resource.

resource "azurerm_service_fabric_cluster" "sf" {
  name                = "test-app-sf"
  resource_group_name = "${azurerm_resource_group.test.name}"
  location            = "${azurerm_resource_group.test.location}"
  reliability_level   = "Bronze"
  upgrade_mode        = "Automatic"
  vm_image            = "Windows"

  management_endpoint = "https://${azurerm_lb.test.private_ip_address}:19080"
  add_on_features     = ["DnsService"]

  certificate {
    thumbprint      = "${azurerm_key_vault_certificate.test.thumbprint}"
    x509_store_name = "My"
  }

  reverse_proxy_certificate {
    thumbprint      = "${azurerm_key_vault_certificate.test.thumbprint}"
    x509_store_name = "My"
  }

  diagnostics_config {
    storage_account_name       = "${azurerm_storage_account.sflogs.name}"
    protected_account_key_name = "StorageAccountKey1"
    blob_endpoint              = "${azurerm_storage_account.sflogs.primary_blob_endpoint}"
    queue_endpoint             = "${azurerm_storage_account.sflogs.primary_queue_endpoint}"
    table_endpoint             = "${azurerm_storage_account.sflogs.primary_table_endpoint}"
  }
  fabric_settings {
    name = "Security"

    parameters = {
      ClusterProtectionLevel = "EncryptAndSign"
    }
  }
  node_type {
    name                 = "backend"
    durability_level     = "Bronze"
    instance_count       = 3
    is_primary           = true
    client_endpoint_port = 19000
    http_endpoint_port   = 19080

    reverse_proxy_endpoint_port = 19081

    ephemeral_ports {
      start_port = 49152
      end_port   = 65534
    }
    application_ports {
      start_port = 20000
      end_port   = 30000
    }
  }
  tags {
    resourceType = "Service Fabric"
    clusterName  = "jms-test-app-sf"
  }
}

@ghost ghost added size/L and removed size/M labels Dec 19, 2018
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @joranm,

Thank you for this contribution! The tests pass and it LGTM aside from the lack of documentation. Once we get that updated it should be good to merge 🙂

@ghost ghost added the documentation label Dec 25, 2018
@joranm
Copy link
Contributor Author

joranm commented Dec 25, 2018

Hi @katbyte, updated the website documentation according to the additions of the reverse proxy certificate and endpoint.

@ghost ghost removed the waiting-response label Dec 25, 2018
@katbyte katbyte added this to the 1.21.0 milestone Dec 26, 2018
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joranm, LGTM now 🙂

@katbyte katbyte merged commit a86ff09 into hashicorp:master Dec 26, 2018
katbyte added a commit that referenced this pull request Dec 26, 2018
@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants