Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for specifying the Partner ID #2643

Merged
merged 5 commits into from
Jan 11, 2019
Merged

Conversation

WodansSon
Copy link
Collaborator

(fixes #2393 )

@ghost ghost added the size/XS label Jan 11, 2019
@WodansSon
Copy link
Collaborator Author

I have chosen not to document this new attribute for a few reasons:

  • This is very specific to Microsoft Partners and would just be noise for a vast majority of our users.
  • There will be a blog about this being exposed
  • Our technical writer will be creating a walk-through explaining how to use this attribute which will be hosted on the docs website.

@tombuildsstuff @katbyte

@ghost ghost added size/S and removed size/XS labels Jan 11, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @jeffreyCline 👍

@WodansSon WodansSon modified the milestones: 2.0.0, 1.21.0 Jan 11, 2019
@WodansSon
Copy link
Collaborator Author

@tombuildsstuff I moved this into 1.21.0 release since I think there is still time to get it in. If you disagree feel free to move it back out into 2.0.0.

Copy link
Contributor

@metacpp metacpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but some minor.

azurerm/config.go Show resolved Hide resolved
@ghost ghost added the documentation label Jan 11, 2019
@tombuildsstuff
Copy link
Contributor

@jeffreyCline after chatting about this with @katbyte we're going to add a brief description into the "advanced options" section, which longer-term can point to a separate blog post for more info :)

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor comment about where the documentation should live (which I'll push a commit to fix) but this otherwise LGTM 👍

website/docs/index.html.markdown Outdated Show resolved Hide resolved
@tombuildsstuff tombuildsstuff changed the title Enhancement: Expose provider partner_id attribute for user-agent string Support for specifying the Partner ID Jan 11, 2019
@tombuildsstuff
Copy link
Contributor

It's green in Travis - no idea why it's still showing as pending ¯_(ツ)_/¯

screenshot 2019-01-11 at 14 06 51

@tombuildsstuff tombuildsstuff merged commit 8d5e9b3 into master Jan 11, 2019
@tombuildsstuff tombuildsstuff deleted the e-tracking-guid branch January 11, 2019 14:08
tombuildsstuff added a commit that referenced this pull request Jan 11, 2019
@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add user_agent argument to azurerm provider
4 participants