Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data.azurerm_network_interface: add missing property ip_configuration.private_ip_address_version #2646

Merged
merged 1 commit into from
Jan 11, 2019

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Jan 11, 2019

before

Test ended in panic.

------- Stdout: -------
=== RUN   TestAccDataSourceArmVirtualNetworkInterface_basic
=== PAUSE TestAccDataSourceArmVirtualNetworkInterface_basic
=== CONT  TestAccDataSourceArmVirtualNetworkInterface_basic

------- Stderr: -------
panic: Invalid address to set: []string{"ip_configuration", "0", "private_ip_address_version"}

after

[17:38:55] kt@snowbook:~/hashi/..3../terraform-providers/terraform-provider-azurerm▸eventhub/fix_acctests$ testazure TestAccDataSourceArmVirtualNetworkInterface_basic
==> Fixing source code with gofmt...
gofmt -s -w ./azurerm
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./azurerm -v -test.run=TestAccDataSourceArmVirtualNetworkInterface_basic -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccDataSourceArmVirtualNetworkInterface_basic
=== PAUSE TestAccDataSourceArmVirtualNetworkInterface_basic
=== CONT  TestAccDataSourceArmVirtualNetworkInterface_basic
--- PASS: TestAccDataSourceArmVirtualNetworkInterface_basic (125.91s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	127.032s

@katbyte katbyte added this to the 1.21.0 milestone Jan 11, 2019
@ghost ghost added the size/XS label Jan 11, 2019
Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@katbyte thanks for the PR, changes LGTM!

@WodansSon
Copy link
Collaborator

@katbyte verified test cases, merging after review.

@WodansSon WodansSon merged commit ec1739c into master Jan 11, 2019
@WodansSon WodansSon deleted the network-if/data.ip_version branch January 11, 2019 04:19
katbyte added a commit that referenced this pull request Jan 11, 2019
@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants