Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_api_management_group #2809

Merged
merged 11 commits into from
Feb 27, 2019
Merged

Conversation

JunyiYi
Copy link

@JunyiYi JunyiYi commented Jan 31, 2019

A simple resource based on azurerm_api_management service. It manages the groups inside that service.

One of work items for #1177.

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @JunyiYi

Thanks for this PR - apologies for the delayed review here!

I've left some comments inline, which I'm going to push some commits for since some of these rely on #2953, I hope you don't mind - but this otherwise LGTM 👍

Thanks!

azurerm/resource_arm_api_management_group.go Outdated Show resolved Hide resolved
azurerm/resource_arm_api_management_group.go Outdated Show resolved Hide resolved
azurerm/resource_arm_api_management_group_test.go Outdated Show resolved Hide resolved
azurerm/resource_arm_api_management_group_test.go Outdated Show resolved Hide resolved
azurerm/resource_arm_api_management_group.go Outdated Show resolved Hide resolved
azurerm/resource_arm_api_management_group.go Outdated Show resolved Hide resolved
@tombuildsstuff
Copy link
Member

tombuildsstuff commented Feb 26, 2019

Blocked on #2945 and #2953

@ghost ghost added size/XL and removed size/XXL labels Feb 27, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from a couple minor comments LGTM 👍

azurerm/data_source_api_management_product.go Show resolved Hide resolved
azurerm/helpers/azure/api_management.go Show resolved Hide resolved
azurerm/helpers/validate/api_management.go Show resolved Hide resolved
@tombuildsstuff
Copy link
Member

Data Source tests pass:

screenshot 2019-02-27 at 14 30 34

Resource tests pass:

screenshot 2019-02-27 at 14 34 02

@tombuildsstuff tombuildsstuff merged commit 28dc73d into master Feb 27, 2019
@tombuildsstuff tombuildsstuff deleted the resource_apimnggroup branch February 27, 2019 13:34
tombuildsstuff added a commit that referenced this pull request Feb 27, 2019
@ghost
Copy link

ghost commented Mar 8, 2019

This has been released in version 1.23.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.23.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 29, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants