add VpnGW skus #3171
add VpnGW skus #3171
Conversation
There was a problem hiding this comment.
hey @Lucretius
Thanks for this PR :)
Taking a look through this LGTM - if we can document these new values then this should be good to merge 👍
Thanks!
| @@ -91,6 +91,9 @@ func resourceArmVirtualNetworkGateway() *schema.Resource { | |||
| string(network.VirtualNetworkGatewaySkuNameErGw1AZ), | |||
| string(network.VirtualNetworkGatewaySkuNameErGw2AZ), | |||
| string(network.VirtualNetworkGatewaySkuNameErGw3AZ), | |||
| string(network.VirtualNetworkGatewaySkuNameVpnGw1AZ), | |||
| string(network.VirtualNetworkGatewaySkuNameVpnGw2AZ), | |||
| string(network.VirtualNetworkGatewaySkuNameVpnGw3AZ), | |||
There was a problem hiding this comment.
|
documentation has been updated with the new values |
tombuildsstuff
force-pushed
the
add-vgw-skus
branch
from
81fddcc
to
e7eccb7
Compare
|
@Lucretius I hope you don't mind but so that we can get this merged I've rebased this |
There was a problem hiding this comment.
hey @Lucretius
Thanks for pushing those changes, so that we can get this merged I've had to rebase this PR - but this now LGTM 👍
Thanks!
|
This has been released in version 1.25.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.25.0"
}
# ... other configuration ... |
|
Hello, I just tested to use the SKU "VpnGw1AZ" and got the following error message Thank you |
|
As discussed on the slack community channel, it appears that the validate function "validateArmVirtualNetworkGatewayRouteBasedVpnSku" doesn't include the SKUs VpnGw1AZ, VpnGw2AZ and VpnGw3AZ for the resource "azurerm_virtual_network_gateway". |
|
Did raise a bug here : #3314 |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Resolves #2383
Unfortunately, these were not available in the existing network API version, so I bumped to the latest one. This is my first time bumping a vendored Go project, not sure what the two changes in the
go.sumfile are all about but the existing unit tests pass and the project builds.