Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add VpnGW skus #3171

Merged
merged 2 commits into from
Apr 6, 2019
Merged

add VpnGW skus #3171

merged 2 commits into from
Apr 6, 2019

Conversation

Lucretius
Copy link
Contributor

Resolves #2383

Unfortunately, these were not available in the existing network API version, so I bumped to the latest one. This is my first time bumping a vendored Go project, not sure what the two changes in the go.sum file are all about but the existing unit tests pass and the project builds.

@ghost ghost added the size/XXL label Apr 4, 2019
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @Lucretius

Thanks for this PR :)

Taking a look through this LGTM - if we can document these new values then this should be good to merge 👍

Thanks!

@@ -91,6 +91,9 @@ func resourceArmVirtualNetworkGateway() *schema.Resource {
string(network.VirtualNetworkGatewaySkuNameErGw1AZ),
string(network.VirtualNetworkGatewaySkuNameErGw2AZ),
string(network.VirtualNetworkGatewaySkuNameErGw3AZ),
string(network.VirtualNetworkGatewaySkuNameVpnGw1AZ),
string(network.VirtualNetworkGatewaySkuNameVpnGw2AZ),
string(network.VirtualNetworkGatewaySkuNameVpnGw3AZ),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lucretius
Copy link
Contributor Author

documentation has been updated with the new values

@ghost ghost removed the waiting-response label Apr 4, 2019
@tombuildsstuff
Copy link
Contributor

@Lucretius I hope you don't mind but so that we can get this merged I've rebased this

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @Lucretius

Thanks for pushing those changes, so that we can get this merged I've had to rebase this PR - but this now LGTM 👍

Thanks!

@tombuildsstuff tombuildsstuff merged commit 58008f1 into hashicorp:master Apr 6, 2019
tombuildsstuff added a commit that referenced this pull request Apr 6, 2019
@ghost
Copy link

ghost commented Apr 17, 2019

This has been released in version 1.25.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.25.0"
}
# ... other configuration ...

@JamesDLD
Copy link

JamesDLD commented Apr 25, 2019

Hello,

I just tested to use the SKU "VpnGw1AZ" and got the following error message
azurerm_virtual_network_gateway.ngw: expected sku to be one of [Basic Standard HighPerformance VpnGw1 VpnGw2 VpnGw3], got VpnGw1AZ (with AzureRm provider version 1.25.0 and Terraform v0.11.13).
FYI @tombuildsstuff @Lucretius

Thank you
James

@JamesDLD
Copy link

As discussed on the slack community channel, it appears that the validate function "validateArmVirtualNetworkGatewayRouteBasedVpnSku" doesn't include the SKUs VpnGw1AZ, VpnGw2AZ and VpnGw3AZ for the resource "azurerm_virtual_network_gateway".

@JamesDLD
Copy link

Did raise a bug here : #3314

@ghost
Copy link

ghost commented May 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators May 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add VpnGw*AZ SKU to the Virtual Network Gateway
3 participants