Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation in resource azurerm_virtual_network_gateway for zone-redundant VPN gateways #3362

Merged
merged 1 commit into from
May 2, 2019

Conversation

dominik-lekse
Copy link
Contributor

Description

This pull request fixes an issue with the azurerm_virtual_network_gateway in which the validation prevents from creating zone-redundant VPN virtual network gateways.

  • In add VpnGW skus #3171, zone-redundant gateway types have been added effectively for ExpressRoute gateway but not yet for VPN gateways.
  • I have cleaned up the validation for the sku attribute to rely on the "sub validators" to avoid ambiguity.

New or Affected Resource(s)

  • azurerm_virtual_network_gateway

References

@ghost ghost added the size/XS label May 2, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea @dominik-lekse! Thanks for this 👍

@katbyte katbyte added this to the v1.28.0 milestone May 2, 2019
@katbyte katbyte merged commit cd861dc into hashicorp:master May 2, 2019
@ghost
Copy link

ghost commented May 17, 2019

This has been released in version 1.28.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.28.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jun 2, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not use VpnGw1AZ, VpnGw2AZ, and VpnGw3AZ SKU's with resource azurerm_virtual_network_gateway
2 participants