Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validation for identity_ids #3183

Merged
merged 2 commits into from
Apr 5, 2019

Conversation

Lucretius
Copy link
Contributor

@Lucretius Lucretius commented Apr 5, 2019

Resolves #3059

identity_ids is still optional, but now if it is specified it must

  1. Not be an empty array
  2. Each entry must not be a UUID.

Not sure if there is another option for this field aside from UUIDs - but if not, we can create a stronger validation checking that all entries are UUIDs.

@ghost ghost added the size/XS label Apr 5, 2019
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @Lucretius

@tombuildsstuff tombuildsstuff added this to the v1.25.0 milestone Apr 5, 2019
@tombuildsstuff tombuildsstuff merged commit acec38e into hashicorp:master Apr 5, 2019
tombuildsstuff added a commit that referenced this pull request Apr 5, 2019
@adamday2
Copy link
Contributor

adamday2 commented Apr 5, 2019

Is this validating that it is a UUID? I was under the impression that this field took in a resource ID of the format:

"/subscriptions/{subscription_id}/resourcegroups/{resource_group}/providers/Microsoft.ManagedIdentity/userAssignedIdentities/"

When attempting to use a UUID, I get this error:

azurerm_virtual_machine.vm-linux-with-msi: compute.VirtualMachinesClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code="LinkedInvalidPropertyId" Message="Property id '{UUID HERE}' at path '' is invalid. Expect fully qualified resource Id that start with '/subscriptions/{subscriptionId}' or '/providers/{resourceProviderNamespace}/'."

@Lucretius
Copy link
Contributor Author

Lucretius commented Apr 5, 2019

Hmm the tests seemed to be checking for a UUID, if this is incorrect I can swap this to a less strict “not empty” check. Definitely don’t want to break this!

Yeah looks like I had been checking the generated principal ID and not the id of the user assigned identity - ill see if I can edit the acceptance test to verify

@Lucretius Lucretius deleted the no-empty-identityids branch April 5, 2019 15:46
katbyte pushed a commit that referenced this pull request Apr 5, 2019
Fixes a bug I introduced in #3183.  Big thanks for the catch by @adamday2
@ghost
Copy link

ghost commented Apr 17, 2019

This has been released in version 1.25.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.25.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators May 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_virtual_machine crash when specifying empty identity_ids in identity block
3 participants