Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application Gateway: removed validation in application gateway #3286

Merged
merged 3 commits into from
Apr 29, 2019
Merged

Application Gateway: removed validation in application gateway #3286

merged 3 commits into from
Apr 29, 2019

Conversation

mcharriere
Copy link
Contributor

Fixes #3285

@ghost ghost added the size/XS label Apr 19, 2019
@ghost ghost added the documentation label Apr 20, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mcharriere,

Thank you for submitting a fix for this. Those validation rules really should be in the expand not the flatten function 🤔

either way i'll get this merged and open a PR to move them later today, this LGTM provided the tests pass 🙂

@katbyte katbyte merged commit 07327d9 into hashicorp:master Apr 29, 2019
katbyte added a commit that referenced this pull request Apr 29, 2019
@mcharriere
Copy link
Contributor Author

Hi @mcharriere,

Thank you for submitting a fix for this. Those validation rules really should be in the expand not the flatten function thinking

either way i'll get this merged and open a PR to move them later today, this LGTM provided the tests pass slightly_smiling_face

hi @katbyte ,
I thought so but I wanted to solve this issue first since this particular validation was not correct.
I can open another issue and send a PR moving the rest of the validations to their respective expand functions.

@ghost
Copy link

ghost commented May 29, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators May 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application gateway: Wrong validation for redirect rules
2 participants