Application gateway: Autoscale configuration #3353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
force-pushed
the
feature/ag-autoscale-configuration
branch
from
f44bbab
to
7404d36
Compare
Co-Authored-By: timja <t.jacomb@kainos.com>
|
All comments should be addressed |
mbfrahry
requested changes
May 7, 2019
There was a problem hiding this comment.
Hey @timja, apologies for missing this on my initial review but we hit quite a few panics after rerunning the application gateway tests. Do you mind taking a look at my comment and seeing if that or something similar makes sense to include?
=== RUN TestAccAzureRMApplicationGateway_authCertificate
=== PAUSE TestAccAzureRMApplicationGateway_authCertificate
=== CONT TestAccAzureRMApplicationGateway_authCertificate
------- Stderr: -------
panic: runtime error: index out of range
goroutine 400 [running]:
github.com/terraform-providers/terraform-provider-azurerm/azurerm.expandAutoscaleConfiguration(0xc0005f28c0, 0xc000a36c60)
/opt/teamcity-agent/work/458e5e4800bd94f6/src/github.com/terraform-providers/terraform-provider-azurerm/azurerm/resource_arm_application_gateway.go:2311 +0x249
github.com/terraform-providers/terraform-provider-azurerm/azurerm.resourceArmApplicationGatewayCreateUpdate(0xc0005f28c0, 0x342c180, 0xc0005b6000, 0x2, 0x680a1a0)
Co-Authored-By: timja <t.jacomb@kainos.com>
mbfrahry
requested changes
May 7, 2019
Co-Authored-By: timja <t.jacomb@kainos.com>
mcharriere
reviewed
May 7, 2019
mcharriere
reviewed
May 7, 2019
…/terraform-provider-azurerm into feature/ag-autoscale-configuration
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2603