Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: azurerm_api_management_api_schema #3357

Merged
merged 3 commits into from
May 2, 2019
Merged

New Resource: azurerm_api_management_api_schema #3357

merged 3 commits into from
May 2, 2019

Conversation

mbfrahry
Copy link
Member

@mbfrahry mbfrahry commented May 2, 2019 

TestAccAzureRMApiManagementApiSchema_basic

@mbfrahry mbfrahry requested a review from a team May 2, 2019 04:06
katbyte
katbyte approved these changes May 2, 2019
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from a couple minor comments LGTM 👍

azurerm/resource_arm_api_management_api_schema.go Show resolved Hide resolved
azurerm/resource_arm_api_management_api_schema_test.go Outdated Show resolved Hide resolved
azurerm/resource_arm_api_management_api_schema_test.go Outdated Show resolved Hide resolved
website/docs/r/api_management_api_schema.html.markdown Outdated Show resolved Hide resolved
@mbfrahry mbfrahry merged commit 7c9738e into master May 2, 2019
@mbfrahry mbfrahry deleted the f-api-management-schema branch May 2, 2019 23:02
@ghost
Copy link

ghost commented Jun 2, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation new-resource service/api-management size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mbfrahry @katbyte