Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added validation for firewall subnet name and forced new resource on change in subnet ID #3406

Merged
merged 3 commits into from
May 10, 2019
Merged

Added validation for firewall subnet name and forced new resource on change in subnet ID #3406

merged 3 commits into from
May 10, 2019

Conversation

jackofallops
Copy link
Member

@jackofallops jackofallops commented May 9, 2019 •
edited by katbyte
Loading

fixes #3299

@ghost ghost added the size/XS label May 9, 2019
@jackofallops jackofallops mentioned this pull request May 9, 2019
Closed
@katbyte katbyte changed the title Issue 3299 - Added validation for firewall subnet name and forced new resource on … Added validation for firewall subnet name and forced new resource on change in subnet ID May 9, 2019
@tombuildsstuff tombuildsstuff added this to the v1.28.0 milestone May 10, 2019
tombuildsstuff
tombuildsstuff requested changes May 10, 2019
View reviewed changes
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @sjones-sot

Thanks for this PR :)

Taking a look through this mostly LGTM, if we can switch over to using the parseAzureResourceID function (to ensure this is valid too) - then we should be able to get this merged 👍

Thanks!

azurerm/resource_arm_firewall.go Outdated Show resolved Hide resolved
@tombuildsstuff
Copy link
Member

Ignoring some unrelated test failures - the tests pass:

Screenshot 2019-05-10 at 15 29 24

tombuildsstuff
tombuildsstuff approved these changes May 10, 2019
View reviewed changes
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @sjones-sot

Thanks for pushing those changes - this now LGTM 👍

@tombuildsstuff tombuildsstuff merged commit 1e47119 into hashicorp:master May 10, 2019
tombuildsstuff added a commit that referenced this pull request May 10, 2019
@tombuildsstuff
Updating to include #3406
93e01b0
@ghost
Copy link

ghost commented May 17, 2019

This has been released in version 1.28.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.28.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jun 10, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
enhancement service/firewall size/XS
Projects
None yet
Milestone
v1.28.0
Development

Successfully merging this pull request may close these issues.

Azure Firewall subnet change
2 participants
@jackofallops @tombuildsstuff