Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application Gateway: Rewrite Rules #3423

Merged
merged 9 commits into from May 17, 2019
Merged

Application Gateway: Rewrite Rules #3423

merged 9 commits into from May 17, 2019

Conversation

mcharriere
Copy link
Contributor

@mcharriere mcharriere commented May 12, 2019

Adds support for rewrite rules #3284

(fixes #3284)

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the pr @mcharriere,

left a few comments inline but overall this is looking pretty good

azurerm/resource_arm_application_gateway_test.go Outdated Show resolved Hide resolved
azurerm/resource_arm_application_gateway_test.go Outdated Show resolved Hide resolved
azurerm/resource_arm_application_gateway.go Outdated Show resolved Hide resolved
azurerm/resource_arm_application_gateway.go Show resolved Hide resolved
azurerm/resource_arm_application_gateway.go Show resolved Hide resolved
azurerm/resource_arm_application_gateway.go Outdated Show resolved Hide resolved
azurerm/resource_arm_application_gateway.go Outdated Show resolved Hide resolved
azurerm/resource_arm_application_gateway.go Outdated Show resolved Hide resolved
@mcharriere
Copy link
Contributor Author

@katbyte I've made the changes in the flatten function checking for nil. Travis is failing but I think it's not related with the code.
I've also added a validation for the rule_sequence param.

Thanks for the review!!

@ghost ghost removed the waiting-response label May 13, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, LGTM 👍

@katbyte
Copy link
Collaborator

katbyte commented May 17, 2019

image

@katbyte katbyte modified the milestones: v1.28.0, v1.29.0 May 17, 2019
@katbyte katbyte merged commit 7a38074 into hashicorp:master May 17, 2019
katbyte added a commit that referenced this pull request May 17, 2019
@ghost
Copy link

ghost commented May 26, 2019

This has been released in version 1.29.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.29.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jun 18, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application Gateway: Rewrite rules
2 participants