Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cosmos db/keyspace/table resources #3442

Merged
merged 25 commits into from
May 16, 2019
Merged

Add cosmos db/keyspace/table resources #3442

merged 25 commits into from
May 16, 2019

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented May 15, 2019

fixes #1671

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good other than the website documentation missing

@ghost ghost added the documentation label May 16, 2019
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @katbyte

Thanks for this PR - taking a look through this mostly LGTM, if we can fix up the minor comments this should otherwise be good to merge 👍

Thanks!

azurerm/resource_arm_cosmos_cassandra_keyspace.go Outdated Show resolved Hide resolved
azurerm/resource_arm_cosmos_cassandra_keyspace_test.go Outdated Show resolved Hide resolved
azurerm/resource_arm_cosmos_cassandra_keyspace_test.go Outdated Show resolved Hide resolved
azurerm/resource_arm_cosmos_mongo_database.go Outdated Show resolved Hide resolved
azurerm/resource_arm_cosmos_cassandra_keyspace.go Outdated Show resolved Hide resolved
azurerm/resource_arm_cosmos_table_test.go Outdated Show resolved Hide resolved
page_title: "Azure Resource Manager: azurerm_cosmos_mongo_database"
sidebar_current: "docs-azurerm-resource-cosmos-mongo-database"
description: |-
Manages a Cosmos Mongo Database.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Manages a Cosmos Mongo Database.
Manages a Mongo Database within a Cosmos DB Account.


# azurerm_cosmos_sql_database

Manages a Cosmos SQL Database.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Manages a Cosmos SQL Database.
Manages a SQL Database within a Cosmos DB Account.


# azurerm_cosmos_table

Manages a Cosmos Table.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Manages a Cosmos Table.
Manages a Table within a Cosmos DB Account.

"azurerm_cosmos_cassandra_keyspace": resourceArmCosmosCassandraKeyspace(),
"azurerm_cosmos_mongo_database": resourceArmCosmosMongoDatabase(),
"azurerm_cosmos_sql_database": resourceArmCosmosSQLDatabase(),
"azurerm_cosmos_table": resourceArmCosmosTable(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make all of these:

Suggested change
"azurerm_cosmos_table": resourceArmCosmosTable(),
"azurerm_cosmosdb_table": resourceArmCosmosTable(),

@katbyte katbyte merged commit 5613a87 into master May 16, 2019
katbyte added a commit that referenced this pull request May 16, 2019
@bentterp
Copy link
Contributor

This is great stuff! Just what we need for what we're building at the moment 🥇

Can we please have a release soon? Pretty please? @tombuildsstuff

@ghost
Copy link

ghost commented May 17, 2019

This has been released in version 1.28.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.28.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jun 16, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: CosmosDB Database
4 participants