provider/azurerm: Add maximum_elastic_worker_count to app_service_plan

[stack72]

@tombuildsstuff so I didn't add this to the deprecated properties block and went with the new way of maximum_number_of_workers

Fixes: #3445

▶ acctests azurerm TestAccDataSourceAzureRMAppServicePlan_premiumSKU
=== RUN   TestAccDataSourceAzureRMAppServicePlan_premiumSKU
=== PAUSE TestAccDataSourceAzureRMAppServicePlan_premiumSKU
=== CONT  TestAccDataSourceAzureRMAppServicePlan_premiumSKU
--- PASS: TestAccDataSourceAzureRMAppServicePlan_premiumSKU (87.91s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	87.978s


▶ acctests azurerm TestAccAzureRMAppServicePlan_premiumConsumptionPlan
=== RUN   TestAccAzureRMAppServicePlan_premiumConsumptionPlan
=== PAUSE TestAccAzureRMAppServicePlan_premiumConsumptionPlan
=== CONT  TestAccAzureRMAppServicePlan_premiumConsumptionPlan
--- PASS: TestAccAzureRMAppServicePlan_premiumConsumptionPlan (83.97s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	84.024s

[katbyte]

Hi @stack72,

Thank you for the PR. I've left some comments inline, with the most important one being adding this property to some tests.

[stack72]

Hi @katbyte, do you have any thoughts on what validation you want added in the question above? I'd love to get this PR finished up :)

[stack72]

@katbyte / @tombuildsstuff so I looked into what Validation was available. The API does have no mention of it:

https://docs.microsoft.com/en-us/azure/templates/microsoft.web/2018-02-01/serverfarms#AppServicePlanProperties

No does the SDK.

I believe this is ready for review again

[tombuildsstuff]

hey @stack72

Thanks for pushing those changes - besides one minor markdown thing to fix (which I'm going to push a commit to fix) this LGTM 👍

Thanks!

[tombuildsstuff]

to not break the formatting, can we make this:

Suggested change

	* `maximum_number_of_workers` - The maximum number of workers supported with the App Service Plan's sku.
	* `maximum_number_of_workers` - The maximum number of workers supported with the App Service Plan's sku.

dismissing since changes have been pushed

[ghost]

This has been released in version 1.30.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.30.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!