Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource: mariadb_firewall_rule #3720

Merged
merged 8 commits into from
Jun 27, 2019

Conversation

juho9000
Copy link
Contributor

Fixes #3715

Mostly a shameless copypaste of mysql_firewall_rule since the resources seem to be pretty much identical.

Sample Terraform code:

resource "azurerm_resource_group" "test" {
  name     = "test"
  location = "North Europe"
}

resource "azurerm_mariadb_server" "test" {
  name                = "test"
  location            = "${azurerm_resource_group.test.location}"
  resource_group_name = "${azurerm_resource_group.test.name}"

  sku {
    name     = "GP_Gen5_2"
    capacity = 2
    tier     = "GeneralPurpose"
    family   = "Gen5"
  }

  storage_profile {
    storage_mb            = 51200
    backup_retention_days = 7
    geo_redundant_backup  = "Disabled"
  }

  administrator_login          = "testlogin"
  administrator_login_password = "testpassword123"
  version                      = "10.2"
  ssl_enforcement              = "Enabled"
}

resource "azurerm_mariadb_firewall_rule" "test" {
  name                = "test"
  resource_group_name = "${azurerm_resource_group.test.name}"
  server_name         = "${azurerm_mariadb_server.test.name}"
  start_ip_address    = "0.0.0.0"
  end_ip_address      = "255.255.255.255"
}

@juho9000
Copy link
Contributor Author

Had the wrong base branch, force-pushed changes.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @juho9000,

Thank you for the new resource! Over all this looks good with most of my comments being minor and around validation/docs. Once those are fixed up this should be good to merge 🙂

azurerm/resource_arm_mariadb_firewall_rule.go Show resolved Hide resolved
azurerm/resource_arm_mariadb_firewall_rule.go Show resolved Hide resolved
azurerm/resource_arm_mariadb_firewall_rule.go Show resolved Hide resolved
azurerm/resource_arm_mariadb_firewall_rule.go Show resolved Hide resolved
website/docs/r/mariadb_firewall_rule_html.markdown Outdated Show resolved Hide resolved
website/docs/r/mariadb_firewall_rule_html.markdown Outdated Show resolved Hide resolved
website/docs/r/mariadb_firewall_rule_html.markdown Outdated Show resolved Hide resolved
website/docs/r/mariadb_firewall_rule_html.markdown Outdated Show resolved Hide resolved
@juho9000
Copy link
Contributor Author

Oops, I had made a few typos while copypasting links in the documentation. Those should be fixed now. :)

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @juho9000, LGTM now 👍

@katbyte katbyte merged commit 26a163e into hashicorp:master Jun 27, 2019
katbyte added a commit that referenced this pull request Jun 27, 2019
@ghost
Copy link

ghost commented Jun 28, 2019

This has been released in version 1.31.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.31.0"
}
# ... other configuration ...

@ghost ghost removed the waiting-response label Jun 28, 2019
@ghost
Copy link

ghost commented Jul 28, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: azurerm_mariadb_firewall_rule not implemented
2 participants