Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_storage_table_entity #3831

Merged
merged 9 commits into from
Jul 12, 2019
Merged

Conversation

mbfrahry
Copy link
Member

@mbfrahry mbfrahry commented Jul 11, 2019

Fixes #1390

--- PASS: TestAccAzureRMTableEntity_basic (93.43s)
--- PASS: TestAccAzureRMTableEntity_update (149.27s)

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM providing the tests pass 👍

azurerm/resource_arm_storage_table_entity.go Outdated Show resolved Hide resolved
website/docs/r/storage_table_entity.html.markdown Outdated Show resolved Hide resolved
website/docs/r/storage_table_entity.html.markdown Outdated Show resolved Hide resolved
website/docs/r/storage_table_entity.html.markdown Outdated Show resolved Hide resolved
website/docs/r/storage_table_entity.html.markdown Outdated Show resolved Hide resolved
website/docs/r/storage_table_entity.html.markdown Outdated Show resolved Hide resolved
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from a couple minor comments LGTM 👍

azurerm/resource_arm_storage_table_entity.go Show resolved Hide resolved
azurerm/resource_arm_storage_table_entity.go Show resolved Hide resolved
website/docs/r/storage_table_entity.html.markdown Outdated Show resolved Hide resolved
azurerm/resource_arm_storage_table_entity_test.go Outdated Show resolved Hide resolved
mbfrahry and others added 6 commits July 11, 2019 16:38
Co-Authored-By: Tom Harvey <tombuildsstuff@users.noreply.github.com>
Co-Authored-By: Tom Harvey <tombuildsstuff@users.noreply.github.com>
Co-Authored-By: Tom Harvey <tombuildsstuff@users.noreply.github.com>
Co-Authored-By: Tom Harvey <tombuildsstuff@users.noreply.github.com>
@mbfrahry mbfrahry merged commit 10eb89e into master Jul 12, 2019
@mbfrahry mbfrahry deleted the f-storage-table-entity branch July 12, 2019 00:11
@ghost
Copy link

ghost commented Jul 30, 2019

This has been released in version 1.32.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.32.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Aug 11, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storage Account - Table - Entity Support
3 participants