Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/storage_account: support for BlockBlobStorage #4131

Merged
merged 1 commit into from Aug 21, 2019
Merged

r/storage_account: support for BlockBlobStorage #4131

merged 1 commit into from Aug 21, 2019

Conversation

tombuildsstuff
Copy link
Member

Fixes #4082

@tombuildsstuff tombuildsstuff added this to the v1.33.0 milestone Aug 21, 2019
@tombuildsstuff tombuildsstuff requested a review from a team August 21, 2019 13:46
@tombuildsstuff tombuildsstuff mentioned this pull request Aug 21, 2019
Closed
katbyte
katbyte approved these changes Aug 21, 2019
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff force-pushed the f/storage-account-blockblobstorage branch from 83d7281 to 171503e Compare August 21, 2019 15:34
@tombuildsstuff
Copy link
Member Author

Tests pass:

$ acctests azurerm TestAccAzureRMStorageAccount_blockBlobStorage
=== RUN   TestAccAzureRMStorageAccount_blockBlobStorage
=== PAUSE TestAccAzureRMStorageAccount_blockBlobStorage
=== CONT  TestAccAzureRMStorageAccount_blockBlobStorage
--- PASS: TestAccAzureRMStorageAccount_blockBlobStorage (94.10s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	94.146s

@tombuildsstuff tombuildsstuff merged commit 51152b9 into master Aug 21, 2019
@tombuildsstuff tombuildsstuff deleted the f/storage-account-blockblobstorage branch August 21, 2019 15:44
tombuildsstuff added a commit that referenced this pull request Aug 21, 2019
@tombuildsstuff
updating to include #4131
ae93d33
@ghost
Copy link

ghost commented Aug 22, 2019

This has been released in version 1.33.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.33.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Sep 21, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation enhancement service/storage size/S
Projects
None yet
Milestone
v1.33.0
Development

Successfully merging this pull request may close these issues.

Support for BlockBlobStorage account kind?
2 participants
@tombuildsstuff @katbyte