Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_kusto_database #4149

Merged

Conversation

r0bnet
Copy link
Contributor

@r0bnet r0bnet commented Aug 26, 2019

This is the second resource for this issue:
#3856

It depends on another open PR (kusto cluster).

@tombuildsstuff
Copy link
Contributor

@r0bnet hey would you mind rebasing this now that #4129 has been merged?

@ghost ghost added size/XL and removed size/XXL labels Aug 30, 2019
@r0bnet
Copy link
Contributor Author

r0bnet commented Aug 30, 2019

@r0bnet hey would you mind rebasing this now that #4129 has been merged?

Hey @tombuildsstuff,
I merged master into this :)

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @r0bnet,

Aside from one comment i've left inline this looks great

azurerm/resource_arm_kusto_database.go Outdated Show resolved Hide resolved
@katbyte katbyte added this to the v1.34.0 milestone Aug 30, 2019
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @r0bnet

Thanks for pushing those changes - taking a look through this now LGTM 👍

@tombuildsstuff tombuildsstuff dismissed katbyte’s stale review September 4, 2019 08:22

dismissing since changes have been pushed

@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2019-09-04 at 10 51 45

@tombuildsstuff
Copy link
Contributor

The Travis error is because of git.apache.org being down (because this isn't rebased off of master containing the fix) - but this is otherwise 👍

@tombuildsstuff tombuildsstuff merged commit 30bd7b6 into hashicorp:master Sep 4, 2019
tombuildsstuff added a commit that referenced this pull request Sep 4, 2019
@ghost
Copy link

ghost commented Sep 18, 2019

This has been released in version 1.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.34.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Oct 4, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants