Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_network_interface: changing the ip_configuration property to no longer force new resource. #4155

Merged
merged 1 commit into from
Sep 9, 2019

Conversation

neil-yechenwei
Copy link
Contributor

@neil-yechenwei neil-yechenwei commented Aug 27, 2019

Issue:
Terraform azurerm recreates network interface when the ip configuration is changed.
[fixes #2746]

Root cause:
The parameter "private_ip_address_version" under ip_configuration object is set to "ForceNew: true,", which causes that terraform destroy and create a new network interface when ip configuration is update.

Fix:
Remove the attribute "ForceNew: true,". Then terraform will just update ip configuration settings under network interface after updated ip configuration.

@ghost ghost added the size/XS label Aug 27, 2019
Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neil, the LGTM... I would like a couple of changes added before we push this.

  • Add a test case for this configuration, as it should be supported since you can do this via portal
  • Update the documentation to reflect the new behavior

@WodansSon
Copy link
Collaborator

Taking a closer look at this and thinking about it a bit more, neither of my requested actions are required...

  • There is already a test case that adds multiple ip configurations
  • There is nothing to document because this is the expected behavior.

Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neil-yechenwei the LGTM! 🚀

@WodansSon
Copy link
Collaborator

image

@WodansSon WodansSon added this to the v1.34.0 milestone Sep 9, 2019
@WodansSon WodansSon merged commit 8a2f636 into hashicorp:master Sep 9, 2019
@WodansSon WodansSon changed the title Fix bug for Azure Network Interface azurerm_network_interface: changing the ip_configuration property to no longer forces new resource. Sep 9, 2019
@WodansSon WodansSon changed the title azurerm_network_interface: changing the ip_configuration property to no longer forces new resource. azurerm_network_interface: changing the ip_configuration property to no longer force new resource. Sep 9, 2019
WodansSon added a commit that referenced this pull request Sep 9, 2019
changing the `ip_configuration` property to no longer force new resource
@ghost
Copy link

ghost commented Sep 18, 2019

This has been released in version 1.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.34.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Oct 10, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Oct 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants