Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-autorest and azure-sdk-for-go to v32.5.0 #4166

Merged
merged 5 commits into from
Aug 28, 2019

Conversation

mbfrahry
Copy link
Member

@mbfrahry mbfrahry commented Aug 27, 2019

* dependencies: updating `github.com/Azure/azure-sdk-for-go` to `v32.5.0`
* dependencies: updating `github.com/Azure/go-autorest` to `v0.9.0`
* dependencies: updating `github.com/hashicorp/go-azure-helpers` to `v0.7.0`
* dependencies: updating `github.com/terraform-providers/terraform-provider-azuread` to `v0.6.0`

@ghost ghost added the size/XXL label Aug 27, 2019
@tombuildsstuff
Copy link
Contributor

this also needed v0.6.0 of github.com/terraform-providers/terraform-provider-azuread vendored - so I'm pushing a commit which runs:

$ GO111MODULE=on go get github.com/terraform-providers/terraform-provider-azuread@v0.6.0
go: finding github.com/terraform-providers/terraform-provider-azuread v0.6.0
go: downloading github.com/terraform-providers/terraform-provider-azuread v0.6.0
go: extracting github.com/terraform-providers/terraform-provider-azuread v0.6.0

$ GO111MODULE=on go mod vendor

@tombuildsstuff tombuildsstuff added this to the v1.34.0 milestone Aug 28, 2019
@tombuildsstuff tombuildsstuff changed the title Update go-autorest and azure-dk-for-go to `v32. Update go-autorest and azure-sdk-for-go to v32.5.0 Aug 28, 2019
@tombuildsstuff tombuildsstuff merged commit 36c33f8 into master Aug 28, 2019
@tombuildsstuff tombuildsstuff deleted the p-sdk-upgrade branch August 28, 2019 12:33
tombuildsstuff added a commit that referenced this pull request Aug 28, 2019
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot to submit the review - but this looked fine to me otherwise 👍

@ghost
Copy link

ghost commented Sep 18, 2019

This has been released in version 1.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.34.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Sep 27, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants