Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: azurerm_app_service_plan and azurerm_app_service_slot crash fixes #4184

Merged
merged 2 commits into from Aug 30, 2019

Conversation

mbfrahry
Copy link
Member

No description provided.

@mbfrahry
Copy link
Member Author

mbfrahry commented Aug 28, 2019

Addressing #3760 and #4083 and #3229

@mbfrahry
Copy link
Member Author

image

@mbfrahry mbfrahry requested a review from a team August 29, 2019 02:55
@tombuildsstuff tombuildsstuff added this to the v1.34.0 milestone Aug 29, 2019
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left some comments inline but this otherwise LGTM 👍

azurerm/helpers/azure/app_service.go Show resolved Hide resolved
azurerm/helpers/azure/app_service.go Outdated Show resolved Hide resolved
azurerm/resource_arm_app_service_slot_test.go Outdated Show resolved Hide resolved
azurerm/resource_arm_app_service_test.go Outdated Show resolved Hide resolved
website/docs/r/app_service.html.markdown Outdated Show resolved Hide resolved
website/docs/r/app_service_slot.html.markdown Outdated Show resolved Hide resolved
@ghost
Copy link

ghost commented Sep 18, 2019

This has been released in version 1.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.34.0"
}
# ... other configuration ...

@jeffadavidson
Copy link

jeffadavidson commented Sep 18, 2019

In version 1.34.0 I am now getting an error that the virtual_network_subnet_id is required

on main.tf line 43, in resource "azurerm_app_service" "*******":
  43:     ip_restriction = [

Inappropriate value for attribute "ip_restriction": element 0: attribute
"virtual_network_subnet_id" is required.

@mbfrahry
Copy link
Member Author

Hi @jeffadavidson, do you mind opening an issue with additional information? Once I have that, I can take a crack at figuring out what's going on.

@ghost
Copy link

ghost commented Sep 30, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants