Adding data source 'azurerm_public_ip_prefix'

[midacts]

This PR is in response to #3748.

I still do not fully understand how everything works (although I would like to learn more), but I think this is all that is required to get this data source added and working.

Acceptance Tests

The test runs successfully.
It creates a public_ip_prefix and also creates a data source of that resource that the test verifies against.
.

Website Documentation

I am pretty sure I got everything correct (but that is one of the main things I am not 100% sure about).

in the Attributes Reference section, I did not add zones as it is specific region only (that is what the resource object says).

[tombuildsstuff]

hey @midacts

Thanks for this PR :)

Taking a look through this mostly LGTM - if we can fix up the minor comments then this should otherwise be good to merge 👍

Thanks!

[midacts]

Thanks for your review and your suggestions.

I will take a look at those and how they work and commit the changes.

[tombuildsstuff]

hey @midacts

Thanks for pushing those changes - taking a look through aside from adding this to the sidebar this otherwise LGTM 👍

Thanks!

[midacts]

Good catch. (Thanks for finding these).
Do you know if there is documentation stating what is required for new data sources and resources?
Things like - add to the website markdown, add to the sidebar, make your tests.

Or even tests to verify everything in the repo is compliant with these rules (so it wouldn't have to manually be checked).

[tombuildsstuff]

@midacts we've got plans to add some contribution documentation in the near-future (it's being tracked in #2688) - however we've intentionally held off doing this until some code reorg. is done as a part of 2.0 (which we've started working on at the moment) - however once the refactoring is done (and we're able to link to the refactored examples in the codebase) this is something we're definitely interested in adding :)

There is a linter for the other bits - however the Azure Provider diverges from other providers (as an example) as we need to nil-check every field in the response (since Azure may return the representation of a resource at the last time it was modified; rather than how the SDK/API Definition states that it should) - so we need to integrate some Azure specific rules into the Terraform Provider linter the broader Terraform team is working on.

[tombuildsstuff]

Test passes:

Thanks again for this @midacts :)

[midacts]

Glad to be able to contribute and learn more about golang, Terraform and the azurerm provider for Terraform.

Thanks for your help.

[ghost]

This has been released in version 1.35.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.35.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!