Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource/Data Source: azurerm_App_Service_Certificate_Order #4454

Merged
merged 16 commits into from
Oct 23, 2019

Conversation

hund030
Copy link

@hund030 hund030 commented Sep 29, 2019

This PR is code implement for issue #2038

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hund030, thanks for opening this PR. The changes here look great but there are some best practices that we should take into account before merging. This mainly has to do with extra values I don't think are necessary in the resource, doc changes, and struct building in the Create/Update function. We also need to add the docs to the sidebar. I'd put the datasource onehere and the resource one here

azurerm/data_source_app_service_certificate_order.go Outdated Show resolved Hide resolved
azurerm/resource_arm_app_service_certificate_order.go Outdated Show resolved Hide resolved
azurerm/resource_arm_app_service_certificate_order.go Outdated Show resolved Hide resolved
azurerm/resource_arm_app_service_certificate_order.go Outdated Show resolved Hide resolved
azurerm/resource_arm_app_service_certificate_order.go Outdated Show resolved Hide resolved
azurerm/resource_arm_app_service_certificate_order.go Outdated Show resolved Hide resolved
website/docs/d/app_service_certificate_order.html.markdown Outdated Show resolved Hide resolved
website/docs/d/app_service_certificate_order.html.markdown Outdated Show resolved Hide resolved
@mbfrahry
Copy link
Member

mbfrahry commented Oct 4, 2019

These tests also look to be quite expensive so we should a conditional at the top of each test that skips them if an environmental variable isn't set. The below should work for that

if os.Getenv("ARM_RUN_TEST_APP_SERVICE_CERTIFICATE") == "" {
    t.Skip("Skipping as ARM_RUN_TEST_APP_SERVICE_CERTIFICATE" is not specified")
}

@hund030 hund030 requested a review from mbfrahry October 15, 2019 03:41
@hund030
Copy link
Author

hund030 commented Oct 21, 2019

all changes applied, waiting for review.

@ghost ghost removed the waiting-response label Oct 21, 2019
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for addressing my concerns. This should make it into the next release.

@mbfrahry mbfrahry merged commit c7e80ce into hashicorp:master Oct 23, 2019
@tombuildsstuff tombuildsstuff added this to the v1.36.0 milestone Nov 20, 2019
@ghost
Copy link

ghost commented Nov 23, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants