azurerm_monitor_action_group: Add Arm Role Receiver and more common alert schema support

[mcdafydd]

Fixes #3603 and comments.

#4483 increased version of azure-sdk-for-go insights import to 2019-06-01. This provides broader support for common alert schema in more receiver types and adds the new ArmRoleReceiver.

[mcdafydd]

I wasn't sure of the best way to get this in the list before getting #4260 merged. This PR is currently a branch off that PR.

[tombuildsstuff]

hey @mcdafydd

Thanks for this PR :)

I've taken a look through and left some comments inline, but this is looking good - if we can fix up the minor comments (and the tests pass) then this otherwise LGTM 👍

Thanks!

[mcdafydd]

Hi @tombuildsstuff and @katbyte - just checking in to confirm whether there is anything else you need from me to get this PR merged. Thanks!

[tombuildsstuff]

@mcdafydd apologies - I can't submit the Review since Github appears to be having issues (but I'll try again in a bit) - what I'm trying to post is / why I've pushed a commit:

---

hey @mcdafydd

Thanks for pushing those changes - apologies for the delayed re-review here!

Running the tests it appears that a few of the assertions are incorrect which is causing them to fail - in particular accessing a list via foo.bar rather than foo.0.bar. Whilst I've gone through and commented where appropriate - for the Resource instead we can take a different approach and use the Import test to verify the fields match the Terraform Configuration (which means we can remove all of the assertions).

As such I hope you don't mind but so that we can get this merged I'm going to push a commit which fixed up the remaining comments and then switches the assertions within the resource for import tests

Thanks!

[tombuildsstuff]

hey @mcdafydd

So running the tests on the whole these look pretty good:

The 4 failing tests are due to #3806 - since that's an existing known issue (and outside the scope of this PR) I think we should be good to merge this for the moment; since from what I can see these should pass once #3806 is resolved.

Thanks!

changes have been pushed - and Github's down so I can't approve it in a new review 🙃

[tombuildsstuff]

LGTM 👍

[ghost]

This has been released in version 1.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.37.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!