Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_function_app - add support for the http2_enabled property #4696

Merged
merged 3 commits into from
Oct 27, 2019

Conversation

aczelandi
Copy link
Contributor

Fixes #4490

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @aczelandi

Thanks for this PR :)

Taking a look through this is looking pretty good - if we can fix up the minor comments this should otherwise be good to merge 👍🏻

Thanks!

azurerm/resource_arm_function_app_test.go Outdated Show resolved Hide resolved
azurerm/resource_arm_function_app.go Outdated Show resolved Hide resolved
@katbyte katbyte changed the title add support for http2 on the azurerm_function_app resource azurerm_function_app - add support for the http2_enabled property Oct 27, 2019
@katbyte katbyte merged commit da37799 into hashicorp:master Oct 27, 2019
@katbyte katbyte modified the milestones: v1.37.0, v1.36.0 Oct 27, 2019
katbyte added a commit that referenced this pull request Oct 27, 2019
@aczelandi aczelandi deleted the support-function-http2 branch October 28, 2019 15:48
@ghost
Copy link

ghost commented Oct 29, 2019

This has been released in version 1.36.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.36.0"
}
# ... other configuration ...

@ghost ghost removed the waiting-response label Oct 29, 2019
@ghost
Copy link

ghost commented Nov 27, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Function_App supporting HTTP 2.0
3 participants