storage_account: Fix Advanced Threat Protection matching for Azure Germany #4746
Conversation
Although the error message returned from Azure Germany Cloud is precisely "The resource namespace 'Microsoft.Security' is invalid." the error message we are seeing in `r/storage_account` has other contents added on it, so we cannot do an equals check directly. The ATP fix was being pushed as v1.36.0, but this change provides the actual resolution. Ref hashicorp#4563, hashicorp#4564.
There was a problem hiding this comment.
hey @sigv
Thanks for this PR - this LGTM 👍
FWIW we're going to move support for Advanced Threat Protection out into it's own resource in the near future, so whilst this will continue to be an issue until 2.0 of the Azure Provider is out - in the longer term this field will be in it's own resource and thus avoidable for most users.
Thanks!
|
This has been released in version 1.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.37.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Although the error message returned from Azure Germany Cloud is precisely "The resource namespace 'Microsoft.Security' is invalid." the error message we are seeing in
r/storage_accounthas other contents added on it, so we cannot do an equals check directly. The ATP fix was being pushed as v1.36.0, but this change provides the actual resolution.Ref #4563, #4564.