Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the error message for the validation of public IP domain name label #485

Merged
merged 1 commit into from
Nov 2, 2017

Conversation

ricoli
Copy link
Contributor

@ricoli ricoli commented Nov 2, 2017

As per the regex, only lowercase characters are allowed.

As per the regex, only lowercase characters are allowed.
@ricoli ricoli changed the title Clarify the error message the public IP domain name label Clarify the error message for the validation of public IP domain name label Nov 2, 2017
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this :)

@tombuildsstuff tombuildsstuff merged commit 89e3432 into hashicorp:master Nov 2, 2017
tombuildsstuff added a commit that referenced this pull request Nov 2, 2017
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants