azurerm_postgres_database allow -s in database collation

[wasfree]

According to feedback from Azure Support we should use hyphens instead of underscore if we create databases in azure postgresql. This PR adress issue #4447

Changes:

• add - to database collation validation
• adjust validation test
• emove hyphen underscore rewrite

Fixes #4447

[katbyte]

Hi @NickMetz,

Thank you for this fix, in addition to the minor comment i've left inline could you add an acceptance test with a - in it to verify that it'll work with the api? thanks!

[wasfree]

Hi @NickMetz,

Thank you for this fix, in addition to the minor comment i've left inline could you add an acceptance test with a - in it to verify that it'll work with the api? thanks!

Hi @katbyte,
there was already an test with hyphen in database collation, but it was expected to cause an error. This behavior was changed. However it makes sense to have an test with failure, that for i have added an test "en@US" which is expected to fail.

[tombuildsstuff]

Tests pass:

[tombuildsstuff]

hey @NickMetz

Thanks for pushing those changes - taking a look through this LGTM 👍

Thanks!

[ghost]

This has been released in version 1.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.37.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!