New Resource: azurerm_network_watcher_flow_log

[katbyte]

continuation of #2262
fixes #1776

[katbyte]

[16:31:42] kt@katbook:~/hashi/tf/azure/azurerm▸flow-log$ testazure TestAccAzureRMNetworkWatcher
==> Fixing source code with gofmt...
# This logic should match the search logic in scripts/gofmtcheck.sh
find . -name '*.go' | grep -v vendor | xargs gofmt -s -w
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./azurerm -v -parallel 11 -test.run=TestAccAzureRMNetworkWatcher -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMNetworkWatcher
=== RUN   TestAccAzureRMNetworkWatcher/FlowLog
=== RUN   TestAccAzureRMNetworkWatcher/FlowLog/trafficAnalytics
=== RUN   TestAccAzureRMNetworkWatcher/FlowLog/basic
=== RUN   TestAccAzureRMNetworkWatcher/FlowLog/disabled
=== RUN   TestAccAzureRMNetworkWatcher/FlowLog/reenabled
=== RUN   TestAccAzureRMNetworkWatcher/FlowLog/retentionPolicy
=== RUN   TestAccAzureRMNetworkWatcher/FlowLog/updateStorageAccount
--- PASS: TestAccAzureRMNetworkWatcher (1010.98s)
    --- PASS: TestAccAzureRMNetworkWatcher/FlowLog (1010.98s)
        --- PASS: TestAccAzureRMNetworkWatcher/FlowLog/trafficAnalytics (289.85s)
        --- PASS: TestAccAzureRMNetworkWatcher/FlowLog/basic (123.60s)
        --- PASS: TestAccAzureRMNetworkWatcher/FlowLog/disabled (113.83s)
        --- PASS: TestAccAzureRMNetworkWatcher/FlowLog/reenabled (151.03s)
        --- PASS: TestAccAzureRMNetworkWatcher/FlowLog/retentionPolicy (154.05s)
        --- PASS: TestAccAzureRMNetworkWatcher/FlowLog/updateStorageAccount (178.61s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	1011.954s
[16:52:57] kt@katbook:~/hashi/tf/azure/azurerm▸flow-log$

[mbfrahry]

LGTM with some minor comments

[tombuildsstuff]

a few minor comments but this otherwise LGTM 👍

[ghost]

This has been released in version 1.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.40.0"
}
# ... other configuration ...

[ThomasStubergh]

Is there any particular reason to why it only supports version 1 flow logs? We have been using version 2 flow logs for a while, and was looking forward to this update where we could set flow logs through terraform only to find out that there is no option to choose flow logs version. Hope this can be implemented as well.

[tombuildsstuff]

@ThomasStubergh mind opening a new issue with more information/an example of a v1 vs v2 flow log? From our side this was an older PR re-opened since the API's been fixed, so it was likely omited since it wasn't historically available. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!