New Resource: `azurerm_storage_account_network_rules` #5082

mbfrahry · 2019-12-05T17:14:07Z

Addresses #3522

--- PASS: TestAccAzureRMStorageAccountNetworkRules_basic (159.91s)
--- PASS: TestAccAzureRMStorageAccountNetworkRules_update (168.75s)

katbyte

Thanks for the PR! left some comments inline but other then those LGTM 👍

katbyte · 2019-12-05T17:42:23Z

azurerm/resource_arm_storage_account_network_rules.go

+						string(storage.Logging),
+						string(storage.Metrics),
+						string(storage.None),
+					}, true),


Is there a reason for the case insensitivy?

Nerp. Came over from some copy pasta

katbyte · 2019-12-05T17:42:33Z

azurerm/resource_arm_storage_account_network_rules.go

+			},
+
+			"virtual_network_subnet_ids": {
+				Type:     schema.TypeList,


Should this be a set?

Sure should

katbyte · 2019-12-05T17:42:45Z

azurerm/resource_arm_storage_account_network_rules.go

+				Type:     schema.TypeList,
+				Optional: true,
+				Computed: true,
+				Elem:     &schema.Schema{Type: schema.TypeString},


And we could validate this is an ID

katbyte · 2019-12-05T17:43:03Z

azurerm/resource_arm_storage_account_network_rules.go

+			},
+
+			"ip_rules": {
+				Type:     schema.TypeList,


Should this be a a set?

Sure should

katbyte · 2019-12-05T17:43:15Z

azurerm/resource_arm_storage_account_network_rules.go

+				Type:     schema.TypeList,
+				Optional: true,
+				Computed: true,
+				Elem:     &schema.Schema{Type: schema.TypeString},


and at least validated with no empty strings?

katbyte · 2019-12-05T17:45:12Z

azurerm/resource_arm_storage_account_network_rules_test.go

+  ip_rules                   = ["127.0.0.1"]
+  virtual_network_subnet_ids = ["${azurerm_subnet.test.id}"]


what happens if we try and create this with nether of these two?

Nothing odd. It creates it with the other parameters specified just fine. Added a test to confirm

katbyte · 2019-12-05T17:45:32Z

azurerm/resource_arm_storage_account_network_rules_test.go

+  ip_rules                   = ["127.0.0.1"]
+  virtual_network_subnet_ids = ["${azurerm_subnet.test.id}"]


could we update these to something different & a different amount?

katbyte · 2019-12-05T17:45:51Z

azurerm/resource_arm_storage_account_network_rules_test.go

+				ImportState:       true,
+				ImportStateVerify: true,
+			},
+		},


Should we add a back to basics step here

Oh, good call

katbyte · 2019-12-05T17:46:25Z

website/docs/r/storage_account_network_rules.html.markdown

+* `bypass` - (Optional)  Specifies whether traffic is bypassed for Logging/Metrics/AzureServices. Valid options are
+any combination of `Logging`, `Metrics`, `AzureServices`, or `None`. 


spurious line break?

katbyte · 2019-12-05T17:46:41Z

website/docs/r/storage_account_network_rules.html.markdown

+* `bypass` - (Optional)  Specifies whether traffic is bypassed for Logging/Metrics/AzureServices. Valid options are
+any combination of `Logging`, `Metrics`, `AzureServices`, or `None`. 
+
+* `ip_rules` - (Optional) List of public IP or IP ranges in CIDR Format. Only IPV4 addresses are allowed. Private IP address ranges (as defined in [RFC 1918](https://tools.ietf.org/html/rfc1918#section-3)) are not allowed.


Should e validate the property as such?

Sure should

tombuildsstuff · 2019-12-06T17:35:02Z

azurerm/resource_arm_storage_account_network_rules.go

+		AccountPropertiesUpdateParameters: &storage.AccountPropertiesUpdateParameters{
+			NetworkRuleSet: &storage.NetworkRuleSet{
+				Bypass:        storage.AzureServices,
+				DefaultAction: storage.DefaultActionDeny,


I think this wants to be Allow?

ghost · 2019-12-07T00:12:51Z

This has been released in version 1.38.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.38.0"
}
# ... other configuration ...

ghost · 2020-01-06T14:50:50Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

mbfrahry added 3 commits December 4, 2019 16:45

Start of storage account network rule set

c4cec07

Finalizing storage account network rules

fa0f4ab

Docs changes

779d9d8

ghost added size/XL documentation labels Dec 5, 2019

mbfrahry added new-resource service/storage labels Dec 5, 2019

mbfrahry added this to the v1.39.0 milestone Dec 5, 2019

katbyte approved these changes Dec 5, 2019

View reviewed changes

mbfrahry added 3 commits December 5, 2019 11:10

Addressing review

7e8925d

goimports

8b6dc05

Fmt

e5a7fb4

mbfrahry merged commit 4e7ebdc into master Dec 6, 2019

mbfrahry deleted the f-storage-account-network-rule branch December 6, 2019 17:32

tombuildsstuff reviewed Dec 6, 2019

View reviewed changes

mbfrahry added a commit that referenced this pull request Dec 6, 2019

Update Changelog.md for #5082

1d872ea

mbfrahry modified the milestones: v1.39.0, v1.38.0 Dec 6, 2019

mbfrahry mentioned this pull request Dec 6, 2019

Initial commit for storage_account_network_rules_association #3741

Closed

tombuildsstuff mentioned this pull request Dec 6, 2019

Create a storage_account_network_rules resource #3522

Closed

geekzter mentioned this pull request Dec 9, 2019

azurerm_storage_account_network_rules ip_rules attribute does not accept CIDR expression #5111

Closed

ghost locked and limited conversation to collaborators Jan 6, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Resource: `azurerm_storage_account_network_rules` #5082

New Resource: `azurerm_storage_account_network_rules` #5082

mbfrahry commented Dec 5, 2019

katbyte left a comment

katbyte Dec 5, 2019

mbfrahry Dec 5, 2019

katbyte Dec 5, 2019

mbfrahry Dec 5, 2019

katbyte Dec 5, 2019

katbyte Dec 5, 2019

mbfrahry Dec 5, 2019

katbyte Dec 5, 2019

katbyte Dec 5, 2019

mbfrahry Dec 5, 2019

katbyte Dec 5, 2019

katbyte Dec 5, 2019

mbfrahry Dec 5, 2019

katbyte Dec 5, 2019

katbyte Dec 5, 2019

mbfrahry Dec 5, 2019

tombuildsstuff Dec 6, 2019

ghost commented Dec 7, 2019

ghost commented Jan 6, 2020

		ip_rules = ["127.0.0.1"]
		virtual_network_subnet_ids = ["${azurerm_subnet.test.id}"]

		* `bypass` - (Optional) Specifies whether traffic is bypassed for Logging/Metrics/AzureServices. Valid options are
		any combination of `Logging`, `Metrics`, `AzureServices`, or `None`.

New Resource: azurerm_storage_account_network_rules #5082

New Resource: azurerm_storage_account_network_rules #5082

Conversation

mbfrahry commented Dec 5, 2019

katbyte left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghost commented Dec 7, 2019

ghost commented Jan 6, 2020

New Resource: `azurerm_storage_account_network_rules` #5082

New Resource: `azurerm_storage_account_network_rules` #5082