Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_function_app - support for ftps_state #5169

Merged
merged 1 commit into from
Dec 16, 2019
Merged

azurerm_function_app - support for ftps_state #5169

merged 1 commit into from
Dec 16, 2019

Conversation

aqche
Copy link
Contributor

@aqche aqche commented Dec 14, 2019

Fixes: #2651

Adds the ftps_state option to the azurerm_function_app resource.

=== RUN   TestAccAzureRMFunctionApp_ftpsState
=== PAUSE TestAccAzureRMFunctionApp_ftpsState
=== CONT  TestAccAzureRMFunctionApp_ftpsState
--- PASS: TestAccAzureRMFunctionApp_ftpsState (161.28s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm       161.328s

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @aqche 👍

@tombuildsstuff tombuildsstuff modified the milestones: v2.0.0, v1.40.0 Dec 16, 2019
@tombuildsstuff
Copy link
Member

Ignoring a couple of known test failures, the tests pass:

Screenshot 2019-12-16 at 07 19 14

@tombuildsstuff tombuildsstuff merged commit d75284f into hashicorp:master Dec 16, 2019
tombuildsstuff added a commit that referenced this pull request Dec 16, 2019
@aqche aqche deleted the support_function_app_ftps_state branch December 17, 2019 04:19
@ghost
Copy link

ghost commented Jan 8, 2020

This has been released in version 1.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.40.0"
}
# ... other configuration ...

@jeanpaulsmit
Copy link
Contributor

Sweet, just what I was looking for!

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set FTP Settings for azurem_function_app
3 participants