Rename Azure Backup and Azure Site Recovery resources #5170
Conversation
There was a problem hiding this comment.
Just one small change and a make fmt and I think we're good. Thanks for opening this @sean-nixon
| @@ -7,7 +7,9 @@ description: |- | |||
| Manages a site recovery services protection container mappings on Azure. | |||
| --- | |||
|
|
|||
| # azurerm_recovery_replicated_vm | |||
| # azurerm_replicated_vm | |||
There was a problem hiding this comment.
I think this still wants to be azurerm_recovery_replicated_vm
azurerm/provider.go
Outdated
| @@ -211,6 +211,8 @@ func Provider() terraform.ResourceProvider { | |||
| "azurerm_azuread_application": resourceArmActiveDirectoryApplication(), | |||
| "azurerm_azuread_service_principal_password": resourceArmActiveDirectoryServicePrincipalPassword(), | |||
| "azurerm_azuread_service_principal": resourceArmActiveDirectoryServicePrincipal(), | |||
| "azurerm_backup_protected_vm": resourceArmRecoveryServicesBackupProtectedVM(), | |||
| "azurerm_backup_policy_vm": resourceArmBackupProtectionPolicyVM(), | |||
There was a problem hiding this comment.
Looks like we need to run make fmt
Addresses #5026 An additional resource beyond the suggested resources in the associated issue was required in order to first register a storage account with a recovery services vault. I've also used an updated naming scheme based on my proposal in #5089 and associated PR #5170 in order to better distinguish Azure Backup resources from Site Recovery (DR) resources. That PR does not technically block this one, but it would make the naming more consistent with the existing Azure Backup resources.
|
This has been released in version 1.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.40.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Fixes #5089
This PR implements the proposed changes in the above issue to better distinguish Azure Site Recovery and Azure Backup resources.