New Resource azurerm_cosmosdb_gremlin_database
#5248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebRosander
changed the title
azurerm_cosmosdb_gremlin_databaseazurerm_cosmosdb_gremlin_database
katbyte
requested changes
Dec 26, 2019
There was a problem hiding this comment.
Hi @SebRosander,
thank you for the new resource! aside from a few minor comments i've left inline this is looking pretty good.
azurerm/internal/services/cosmos/resource_arm_cosmosdb_gremlin_database.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/cosmos/resource_arm_cosmosdb_gremlin_database.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/cosmos/tests/resource_arm_cosmosdb_gremlin_database_test.go
Show resolved
Hide resolved
azurerm/internal/services/cosmos/resource_arm_cosmosdb_gremlin_database.go
Show resolved
Hide resolved
katbyte
approved these changes
Dec 26, 2019
katbyte
added a commit
that referenced
this pull request
Dec 26, 2019
jackbatzner
pushed a commit
to jackbatzner/terraform-provider-azurerm
that referenced
this pull request
Dec 31, 2019
Fixes some parts of hashicorp#3692 and hashicorp#4970
jackbatzner
pushed a commit
to jackbatzner/terraform-provider-azurerm
that referenced
this pull request
Dec 31, 2019
|
This has been released in version 1.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.40.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some parts of #3692 and #4970
Tests passing:
=== RUN TestAccAzureRMCosmosGremlinDatabase_complete
=== PAUSE TestAccAzureRMCosmosGremlinDatabase_complete
=== CONT TestAccAzureRMCosmosGremlinDatabase_complete
--- PASS: TestAccAzureRMCosmosGremlinDatabase_complete (1160.85s)
PASS
=== RUN TestAccAzureRMCosmosGremlinDatabase_basic
=== PAUSE TestAccAzureRMCosmosGremlinDatabase_basic
=== CONT TestAccAzureRMCosmosGremlinDatabase_basic
--- PASS: TestAccAzureRMCosmosGremlinDatabase_basic (1097.21s)