Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Data Source/Resource: azurerm_dedicated_host_group #5307

Merged
merged 4 commits into from
Jan 9, 2020

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Jan 4, 2020

Add new resource dedicated_host_group, which belongs to Compute Provider.

A host group is a resource that represents a collection of dedicated hosts. You create a host group in a region and an availability zone, and add hosts to it.

Please refer to this link for more info.

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @magodo

Thanks for this PR - apologies for the delayed review here!

Taking a look through this is off to a good start, I've left some comments inline but if we can fix up the comments (and the tests pass) then this should otherwise be good 👍

Thanks!

website/docs/r/dedicated_host_group.html.markdown Outdated Show resolved Hide resolved
website/docs/r/dedicated_host_group.html.markdown Outdated Show resolved Hide resolved
website/docs/r/dedicated_host_group.html.markdown Outdated Show resolved Hide resolved
website/docs/d/dedicated_host_group.html.markdown Outdated Show resolved Hide resolved
website/docs/r/dedicated_host_group.html.markdown Outdated Show resolved Hide resolved
Including:

- Remove `host_ids` from data source
- document/format
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @magodo

Thanks for pushing those changes - taking a look through this now LGTM; I hope you don't mind but I've pushed a commit to fix the linting so that we can get this merged 👍

Thanks!

@tombuildsstuff tombuildsstuff added this to the v1.41.0 milestone Jan 9, 2020
@tombuildsstuff tombuildsstuff changed the title new resource dedicated host group New Data Source/Resource: azurerm_dedicated_host_group Jan 9, 2020
@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2020-01-09 at 12 24 25

@tombuildsstuff tombuildsstuff merged commit 2ee890c into hashicorp:master Jan 9, 2020
tombuildsstuff added a commit that referenced this pull request Jan 9, 2020
@magodo
Copy link
Collaborator Author

magodo commented Jan 9, 2020

@tombuildsstuff Thank you 🎉

@ghost
Copy link

ghost commented Jan 16, 2020

This has been released in version 1.41.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.41.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Feb 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Feb 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants