azurerm_function_app: convert connection_strings from a TypList to a TypeSet (#3596)

[levvko]

Converted function app connection strings to Set, as it was previously done for app service
#3596

Fixes #3596

[tombuildsstuff]

hey @levvko

Thanks for this PR :)

Taking a look through whilst this converts the property to being a Set we also need to update the Expand function, else Terraform will crash when trying to parse/expand the Connection Strings block - however if we can update that then we should be able to run the tests and get this merged 👍

Thanks!

[tombuildsstuff]

in addition to this we also need to update the expand function to use: d.Get("foo").(*schema.Set).([]interface{} rather than d.Get("foo").([]interface{}) since this is now a Set rather than a List

[katbyte]

Thanks for the revision @levvko! LGTM now 👍

[ghost]

This has been released in version 1.41.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.41.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!