Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new data source: azurerm_sentinel_alert_rule_template #7020

Merged
merged 4 commits into from Jan 14, 2021

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented May 20, 2020

This PR implement the alert rule template required in #6448.

Test Result

💤 via 🦉 v1.14.2 make testacc TEST=./azurerm/internal/services/sentinel/tests TESTARGS="-run TestAccDataSourceSentinelAlertRuleTemplate_"
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
TF_ACC=1 go test ./azurerm/internal/services/sentinel/tests -v -run TestAccDataSourceSentinelAlertRuleTemplate_ -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccDataSourceSentinelAlertRuleTemplate_fusionAlertRuleTemplate
=== PAUSE TestAccDataSourceSentinelAlertRuleTemplate_fusionAlertRuleTemplate
=== RUN   TestAccDataSourceSentinelAlertRuleTemplate_msSecurityIncidentAlertRuleTemplate
=== PAUSE TestAccDataSourceSentinelAlertRuleTemplate_msSecurityIncidentAlertRuleTemplate
=== RUN   TestAccDataSourceSentinelAlertRuleTemplate_scheduledAlertRuleTemplate
=== PAUSE TestAccDataSourceSentinelAlertRuleTemplate_scheduledAlertRuleTemplate
=== CONT  TestAccDataSourceSentinelAlertRuleTemplate_fusionAlertRuleTemplate
=== CONT  TestAccDataSourceSentinelAlertRuleTemplate_scheduledAlertRuleTemplate
=== CONT  TestAccDataSourceSentinelAlertRuleTemplate_msSecurityIncidentAlertRuleTemplate
--- PASS: TestAccDataSourceSentinelAlertRuleTemplate_msSecurityIncidentAlertRuleTemplate (232.73s)
--- PASS: TestAccDataSourceSentinelAlertRuleTemplate_fusionAlertRuleTemplate (232.74s)
--- PASS: TestAccDataSourceSentinelAlertRuleTemplate_scheduledAlertRuleTemplate (232.73s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/sentinel/tests      232.762s

@magodo
Copy link
Collaborator Author

magodo commented Jan 13, 2021

Hi @tombuildsstuff , I've refine the sentinel alert rule template data source, which helps users to use alert rule (especially for azurerm_sentinel_alert_rule_fusion), see the updated test case in my PR based on that in #9829. Would you mind take a look?

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @magodo - Left some comment sinline to address

@magodo
Copy link
Collaborator Author

magodo commented Jan 13, 2021

@katbyte Thank you for the review. I've resolved all the comments, please take another look!

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @magodo - LGTM 👍

@katbyte katbyte added this to the v2.43.0 milestone Jan 14, 2021
@katbyte katbyte merged commit 2e7f23c into hashicorp:master Jan 14, 2021
@ghost
Copy link

ghost commented Jan 14, 2021

This has been released in version 2.43.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.43.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Feb 13, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked as resolved and limited conversation to collaborators Feb 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants