Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_eventgrid_event_subscription - deprecate topic_name #7871

Merged
merged 2 commits into from
Jul 24, 2020

Conversation

neil-yechenwei
Copy link
Contributor

fixes #3305

According by the PR, topic_name has been changed to readonly field. So I remove this unnecessary field.

--- PASS: TestAccAzureRMEventGridEventSubscription_advancedFilter (307.33s)
--- PASS: TestAccAzureRMEventGridEventSubscription_filter (372.90s)
--- PASS: TestAccAzureRMEventGridEventSubscription_requiresImport (383.96s)
--- PASS: TestAccAzureRMEventGridEventSubscription_basic (401.60s)
--- PASS: TestAccAzureRMEventGridEventSubscription_serviceBusQueueID (430.50s)
--- PASS: TestAccAzureRMEventGridEventSubscription_serviceBusTopicID (522.11s)
--- PASS: TestAccAzureRMEventGridEventSubscription_eventHubID (531.38s)
--- PASS: TestAccAzureRMEventGridEventSubscription_update (647.02s)
PASS

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from one comment this LGTM 👍

Type: schema.TypeString,
Optional: true,
Computed: true,
Deprecated: "This field has been updated to readonly field since Apr 25, 2019. So remove this unnecessary field.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Deprecated: "This field has been updated to readonly field since Apr 25, 2019. So remove this unnecessary field.",
Deprecated: "This field has been updated to readonly field since Apr 25, 2019 so no longer has any affect and will be removed in version 3.0 of the provider.",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated. thx

@katbyte katbyte added the service/event-grid EventGrid label Jul 23, 2020
@katbyte katbyte added this to the v2.21.0 milestone Jul 23, 2020
@katbyte katbyte added the bug label Jul 24, 2020
@katbyte katbyte changed the title Deprecate topic_name for azurerm_eventgrid_event_subscription azurerm_eventgrid_event_subscription - deprecate topic_name Jul 24, 2020
@katbyte katbyte merged commit 40ad304 into hashicorp:master Jul 24, 2020
katbyte added a commit that referenced this pull request Jul 24, 2020
@ghost
Copy link

ghost commented Jul 31, 2020

This has been released in version 2.21.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.21.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Aug 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EventGrid Subscriptions resource invalid topic name error
2 participants