Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update azurerm_disk_encryption_set - Support key rotation #7913

Merged

Conversation

ArcturusZhang
Copy link
Contributor

Fixes #7858

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff added this to the v2.41.0 milestone Dec 10, 2020
@tombuildsstuff
Copy link
Member

Tests pass:

Screenshot 2020-12-10 at 14 33 54

@tombuildsstuff tombuildsstuff merged commit 1af41c4 into hashicorp:master Dec 11, 2020
tombuildsstuff added a commit that referenced this pull request Dec 11, 2020
@ArcturusZhang ArcturusZhang deleted the enable-key-rotation-for-des branch December 14, 2020 03:17
@ghost
Copy link

ghost commented Dec 17, 2020

This has been released in version 2.41.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.41.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jan 10, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rotate key on disk encryption set on Azure
2 participants