Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed parsing of management group id #8024

Merged
merged 1 commit into from
Sep 11, 2020
Merged

Fixed parsing of management group id #8024

merged 1 commit into from
Sep 11, 2020

Conversation

simongh
Copy link
Contributor

@simongh simongh commented Aug 5, 2020

I think this addresses #8023

@ghost ghost added the size/XS label Aug 5, 2020
Copy link
Contributor

@ArcturusZhang ArcturusZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @simongh thanks for this PR!

This PR looks great to me. But could you please also add more test cases in this file: https://github.com/terraform-providers/terraform-provider-azurerm/blob/594d00c830cb375148a3b42753b65c42d3696191/azurerm/internal/services/managementgroup/parse/management_group_test.go?

I suppose add new cases with ManagementGroups segment should work.

Thanks!

@simongh
Copy link
Contributor Author

simongh commented Aug 21, 2020

Added a couple of tests with alternate casing

@ghost ghost removed the waiting-response label Aug 21, 2020
Copy link
Contributor

@ArcturusZhang ArcturusZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 thanks!

@dpbustos
Copy link

When will this PR be merged in?

@katbyte katbyte added this to the v2.28.0 milestone Sep 11, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@katbyte katbyte merged commit 9876575 into hashicorp:master Sep 11, 2020
katbyte added a commit that referenced this pull request Sep 11, 2020
@ghost
Copy link

ghost commented Sep 17, 2020

This has been released in version 2.28.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.28.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Oct 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 12, 2020
@simongh simongh deleted the patch-4 branch February 18, 2021 10:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants