new resource azurerm_synapse_sql_pool

[njuCZ]

the third resource of #7406

it needs to take a long time to run test for PointInTime restore (8h according to the doc) and recovery (1 day), so I don't add test case for these two create mode. I have tested it offline and there is no problem

(fixes #7406)

[katbyte]

Thanks @njuCZ - aside from a few minor comments this looks pretty good

[njuCZ]

@katbyte I have refined my PR, could you please have a look again?

Requested changes have been made.

[WodansSon]

@njuCZ, thanks for pushing the requested changes by @katbyte ... LGTM! 🚀

[tombuildsstuff]

hi @njuCZ

Thanks for this PR.

I've taken a look through here and left some comments inline - but this is off to a good start. If we can fix up the comments then we should be able to take another look through here.

Thanks!

[tombuildsstuff]

this looks like a value that'll change in the future:

a) is this defaulted off?
b) is this going to change to on in the future?
c) is this not a ForceNew field like in many other API's?

[njuCZ]

a) for now, it's default "off"
b) I am sorry that I don't know whether it will change default value in the future
c) it's a updatable field. I don't see similiar fields in other API?

[tombuildsstuff]

we should default this within Terraform too:

Suggested change

	* `collation` - (Optional) The name of the collation to use with this pool. Applies only if `create_mode` is `Default`. Azure default is `SQL_LATIN1_GENERAL_CP1_CI_AS`. Changing this forces a new resource to be created.
	* `collation` - (Optional) The name of the collation to use with this pool, only applicable when `create_mode` is set to `Default`. Defaults to `SQL_LATIN1_GENERAL_CP1_CI_AS`. Changing this forces a new resource to be created.

[njuCZ]

we could not add default value here, the reason is as below

[tombuildsstuff]

(as below) this should probably be defaulted

I believe we've also got validation for collations somewhere in the codebase we could use here

[njuCZ]

I have added validation. But I think this field should not have default value. Because in "recovery" or "restore" createmode, the "collation" is the same with the sourceDatabase, but not what user input. If there is a default value, it might cause diff in this case.

[njuCZ]

@tombuildsstuff I have modifed this PR, could you please have a look again?

[jackofallops]

Hi @njuCZ - Is there a reason this is leveraging/updating sql rather than the newer mssql ?

[katbyte]

Thanks @njuCZ - LGTM 👍

[njuCZ]

@jackofallops sorry that I understand the relation between sql and mssql just now. Since this PR has been merged, and only parse function and validation function from sql package is used. I will change to use functions from mssql. This is not breaking change and I will submit follow up PR to do this #8434 . Thanks for your suggestion

[ghost]

This has been released in version 2.28.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.28.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!