Update azurerm_policy_set_definition - Support to use non-string typed parameter values in policy_definition_reference block
#8270
Conversation
ArcturusZhang
force-pushed
the
fix-policy-set-definition
branch
from
b8ccb58
to
a6ca072
Compare
There was a problem hiding this comment.
hey @ArcturusZhang
Thanks for this PR.
I've taken a look through and left some comments inline, but this is off to a good start. If we can fix the comments up (and the tests pass) then this otherwise LGTM 👍
Thanks!
azurerm/internal/services/policy/policy_set_definition_resource.go
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| definition := policy.SetDefinition{ | ||
| Name: utils.String(name), |
There was a problem hiding this comment.
is this intentionally removed?
There was a problem hiding this comment.
Yes, this name parameter is read only, it will be ignored when building the request, therefore there is no point setting it here
azurerm/internal/services/policy/policy_set_definition_resource.go
Outdated
Show resolved
Hide resolved
|
HI @tombuildsstuff I have made some changes, please have a look, thanks |
|
This has been released in version 2.29.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.29.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Fixes #8159