Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New data source: azurerm_databricks_workspace #8502

Merged
merged 11 commits into from
Sep 19, 2020
Merged

New data source: azurerm_databricks_workspace #8502

merged 11 commits into from
Sep 19, 2020

Conversation

favoretti
Copy link
Collaborator

Fixes #8475

@ghost ghost added the size/M label Sep 17, 2020
@ghost ghost added documentation size/L and removed size/M labels Sep 17, 2020
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @favoretti

Thanks for this PR :)

Taking a look through this mostly LGTM - if we can fix up the comments then we should be able to run the tests and get this merged 👍

Thanks!

@favoretti
Copy link
Collaborator Author

(⎈ |eastus2-fxs-oscar-np-fxc:build-agents)➜  terraform-providers/terraform-provider-azurerm git:(favoretti/databricks_workspace_datasource) $ make acctests SERVICE='databricks' TESTARGS='-run=TestAccDataSourceAzureRMDatabricksWorkspace' TESTTIMEOUT='60m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./azurerm/internal/services/databricks/tests/ -run=TestAccDataSourceAzureRMDatabricksWorkspace -timeout 60m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccDataSourceAzureRMDatabricksWorkspace_basic
=== PAUSE TestAccDataSourceAzureRMDatabricksWorkspace_basic
=== CONT  TestAccDataSourceAzureRMDatabricksWorkspace_basic
--- PASS: TestAccDataSourceAzureRMDatabricksWorkspace_basic (569.69s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/databricks/tests	570.802s

@ghost ghost removed the waiting-response label Sep 17, 2020
@katbyte katbyte added this to the v2.29.0 milestone Sep 19, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @favoretti - LGTM 👍

@katbyte katbyte merged commit ba71bb4 into hashicorp:master Sep 19, 2020
katbyte added a commit that referenced this pull request Sep 19, 2020
@ghost
Copy link

ghost commented Sep 24, 2020

This has been released in version 2.29.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.29.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Oct 20, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Databricks Workspace Data Source
3 participants