Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_sentinel_alert_rule_scheduled: support incident configuration #8564

Merged

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Sep 22, 2020

Fixes: #8545

Test Result

💤 make testacc TEST=./azurerm/internal/services/sentinel/tests TESTARGS='-run TestAccAzureRMSentinelAlertRuleScheduled_'

==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test ./azurerm/internal/services/sentinel/tests -v -run TestAccAzureRMSentinelAlertRuleScheduled_ -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMSentinelAlertRuleScheduled_basic
=== PAUSE TestAccAzureRMSentinelAlertRuleScheduled_basic
=== RUN   TestAccAzureRMSentinelAlertRuleScheduled_complete
=== PAUSE TestAccAzureRMSentinelAlertRuleScheduled_complete
=== RUN   TestAccAzureRMSentinelAlertRuleScheduled_update
=== PAUSE TestAccAzureRMSentinelAlertRuleScheduled_update
=== RUN   TestAccAzureRMSentinelAlertRuleScheduled_requiresImport
=== PAUSE TestAccAzureRMSentinelAlertRuleScheduled_requiresImport
=== CONT  TestAccAzureRMSentinelAlertRuleScheduled_basic
=== CONT  TestAccAzureRMSentinelAlertRuleScheduled_requiresImport
=== CONT  TestAccAzureRMSentinelAlertRuleScheduled_complete
=== CONT  TestAccAzureRMSentinelAlertRuleScheduled_update
--- PASS: TestAccAzureRMSentinelAlertRuleScheduled_complete (136.38s)
--- PASS: TestAccAzureRMSentinelAlertRuleScheduled_basic (137.29s)
--- PASS: TestAccAzureRMSentinelAlertRuleScheduled_requiresImport (139.64s)
--- PASS: TestAccAzureRMSentinelAlertRuleScheduled_update (254.06s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/sentinel/tests      254.116s

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @magodo - overall this is off to a good start. I've left some comments inline that once addressed this should be good to merge

@magodo
Copy link
Collaborator Author

magodo commented Oct 12, 2020

@katbyte Thank you for your review! I have updated accordingly, please take another look!

@katbyte
Copy link
Collaborator

katbyte commented Dec 30, 2020

@magodo - could we fix the merge conflicts? once thats done i think this is good to merge

@magodo
Copy link
Collaborator Author

magodo commented Dec 31, 2020

@katbyte I've resolved the conflicts, please take another look!

💤 make testacc TEST=./azurerm/internal/services/sentinel TESTARGS='-run TestAccSentinelAlertRuleScheduled_'     
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test ./azurerm/internal/services/sentinel -v -run TestAccSentinelAlertRuleScheduled_ -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccSentinelAlertRuleScheduled_basic
=== PAUSE TestAccSentinelAlertRuleScheduled_basic
=== RUN   TestAccSentinelAlertRuleScheduled_complete
=== PAUSE TestAccSentinelAlertRuleScheduled_complete
=== RUN   TestAccSentinelAlertRuleScheduled_update
=== PAUSE TestAccSentinelAlertRuleScheduled_update
=== RUN   TestAccSentinelAlertRuleScheduled_requiresImport
=== PAUSE TestAccSentinelAlertRuleScheduled_requiresImport
=== RUN   TestAccSentinelAlertRuleScheduled_withAlertRuleTemplateGuid
=== PAUSE TestAccSentinelAlertRuleScheduled_withAlertRuleTemplateGuid
=== CONT  TestAccSentinelAlertRuleScheduled_basic
=== CONT  TestAccSentinelAlertRuleScheduled_requiresImport
=== CONT  TestAccSentinelAlertRuleScheduled_update
=== CONT  TestAccSentinelAlertRuleScheduled_complete
=== CONT  TestAccSentinelAlertRuleScheduled_withAlertRuleTemplateGuid
--- PASS: TestAccSentinelAlertRuleScheduled_basic (208.04s)
--- PASS: TestAccSentinelAlertRuleScheduled_complete (210.88s)
--- PASS: TestAccSentinelAlertRuleScheduled_withAlertRuleTemplateGuid (214.42s)
--- PASS: TestAccSentinelAlertRuleScheduled_requiresImport (219.25s)
--- PASS: TestAccSentinelAlertRuleScheduled_update (457.98s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/sentinel    458.025s

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@katbyte katbyte added this to the v2.42.0 milestone Jan 1, 2021
@katbyte katbyte merged commit ab4798b into hashicorp:master Jan 1, 2021
katbyte added a commit that referenced this pull request Jan 1, 2021
@ghost
Copy link

ghost commented Jan 8, 2021

This has been released in version 2.42.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.42.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jan 31, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for incident configuration for azurerm_sentinel_alert_rule_scheduled
3 participants