Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_kubernetes_cluster - min_count can be updated when enable_auto_scaling is set to true #8619

Merged
merged 6 commits into from
Oct 22, 2020

Conversation

neil-yechenwei
Copy link
Contributor

fixes #8576

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @neil-yechenwei - could we get a test added to validate this?

@ghost ghost added size/M and removed size/XS labels Oct 9, 2020
@neil-yechenwei
Copy link
Contributor Author

@katbyte , thanks for your comment. Test case is added.

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry changed the title Update the validation for min_count and node_count while updating azurerm_kubernetes_cluster - min_count can be updated when enable_auto_scaling is set to true Oct 22, 2020
@mbfrahry mbfrahry added this to the v2.34.0 milestone Oct 22, 2020
@mbfrahry mbfrahry merged commit 69d4677 into hashicorp:master Oct 22, 2020
mbfrahry added a commit that referenced this pull request Oct 22, 2020
@ghost
Copy link

ghost commented Oct 29, 2020

This has been released in version 2.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.34.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Nov 22, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_kubernetes_cluster - unable to increase min_node value when auto scale is enabled
3 participants