-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_security_center_contact - override SDK creation function to handle 201
response code
#8774
Conversation
a804d83
to
ec86408
Compare
ec86408
to
759614c
Compare
759614c
to
7afac2e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @beandrad
Thanks for this PR :)
Taking a look through this is looking good, if we can fix up a couple of minor comments then this otherwise LGTM 👍
Thanks!
azurerm/internal/services/securitycenter/azuresdkhacks/security_center_contact.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/securitycenter/resource_arm_security_center_contact.go
Show resolved
Hide resolved
7afac2e
to
66549d4
Compare
@tombuildsstuff thanks for reviewing! changes made! |
ec32f45
to
94424c9
Compare
711a4d6
to
ac502ca
Compare
ac502ca
to
1f9869b
Compare
1f9869b
to
efe7ba7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @beandrad
Thanks for pushing those changes - if we can rebase this and update the vendoring then this otherwise LGTM 👍
efe7ba7
to
55f87df
Compare
This allows to create a new security center contact. The issue is that the Azure Rest API may return a 201 upon resource creation, however the API specs don't include this status code as successful, which causes the corresponding method from the Azure Go SDK to return an error. Fixes hashicorp#8317
55f87df
to
0fb3370
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for pushing those changes @beandrad
201
response code
This has been released in version 2.32.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.32.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
This allows to create a new security center contact.
The current issue is that the Azure Rest API may return a 201 upon resource
creation, however, the API specs don't include this status code as
successful, which causes the corresponding method from the Azure Go SDK
to return an error.
Fixes #8317