Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource/ data source azurerm_storage_encryption_scope #8894

Merged
merged 20 commits into from Nov 19, 2020

Conversation

yupwei68
Copy link
Contributor

Fix #8893

=== RUN TestAccAzureRMStorageEncryptionScope_basic
=== PAUSE TestAccAzureRMStorageEncryptionScope_basic
=== CONT TestAccAzureRMStorageEncryptionScope_basic
--- PASS: TestAccAzureRMStorageEncryptionScope_basic (136.38s)
=== RUN TestAccAzureRMStorageEncryptionScope_requiresImport
=== PAUSE TestAccAzureRMStorageEncryptionScope_requiresImport
=== CONT TestAccAzureRMStorageEncryptionScope_requiresImport
--- PASS: TestAccAzureRMStorageEncryptionScope_requiresImport (146.85s)
=== RUN TestAccAzureRMStorageEncryptionScope_completeSourceStorage
=== PAUSE TestAccAzureRMStorageEncryptionScope_completeSourceStorage
=== CONT TestAccAzureRMStorageEncryptionScope_completeSourceStorage
--- PASS: TestAccAzureRMStorageEncryptionScope_completeSourceStorage (136.50s)
=== RUN TestAccAzureRMStorageEncryptionScope_completeSourceKeyVault
=== PAUSE TestAccAzureRMStorageEncryptionScope_completeSourceKeyVault
=== CONT TestAccAzureRMStorageEncryptionScope_completeSourceKeyVault
--- PASS: TestAccAzureRMStorageEncryptionScope_completeSourceKeyVault (294.01s)
=== RUN TestAccAzureRMStorageEncryptionScope_update
=== PAUSE TestAccAzureRMStorageEncryptionScope_update
=== CONT TestAccAzureRMStorageEncryptionScope_update
--- PASS: TestAccAzureRMStorageEncryptionScope_update (493.35s)

=== RUN TestAccDataSourceAzureRMStorageEncryptionScope_basic
=== PAUSE TestAccDataSourceAzureRMStorageEncryptionScope_basic
=== CONT TestAccDataSourceAzureRMStorageEncryptionScope_basic
--- PASS: TestAccDataSourceAzureRMStorageEncryptionScope_basic (140.63s)

@yupwei68
Copy link
Contributor Author

I've merged the master branch. Please continue reviewing.

@tombuildsstuff tombuildsstuff added this to the v2.37.0 milestone Nov 19, 2020
@tombuildsstuff
Copy link
Member

Looks like this also requires changes to Giovanni to support the BlobEncryptionScope to be able to test this end-to-end: https://docs.microsoft.com/en-us/rest/api/storageservices/put-block

@tombuildsstuff tombuildsstuff modified the milestones: v2.37.0, Blocked Nov 19, 2020
@tombuildsstuff
Copy link
Member

For now it looks like we should be able to ship this without the Blob and Containers support, but that'll require work in both the Giovanni SDK and (subsequently) those resources to support Encryption Scopes on those resources.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from one cOmment LGTM 👍

@tombuildsstuff
Copy link
Member

Tests pass:

Screenshot 2020-11-19 at 20 41 35

@tombuildsstuff tombuildsstuff merged commit aaa9bef into hashicorp:master Nov 19, 2020
tombuildsstuff added a commit that referenced this pull request Nov 19, 2020
@ghost
Copy link

ghost commented Nov 20, 2020

This has been released in version 2.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.37.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Dec 20, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked as resolved and limited conversation to collaborators Dec 20, 2020
@yupwei68 yupwei68 deleted the wyp-storage-es branch January 25, 2021 02:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Storage Encryption Scope
3 participants